Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Allow users to configure Inventory View palettes #66948

Merged

Conversation

simianhacker
Copy link
Member

Summary

This PR closes #65913 by enhancing the legend configuration options to include the color palette settings. This also changes how the min/max work by using auto-correction to ensure the user doesn't make mistakes.

image

Testing Checklist

  • Ensure you can save color palettes with views
  • Ensure you can restore views with custom palettes
  • Change the bounds to a smaller range then the data. Ensure nodes above the maxium are colored with the max color and the nodes below the minimum are colored with the min color.
  • Change the steps to 2, ensure there are only 2 colors used on the map.
  • Try to create a minimum above the maximum, ensure it autocorrects to one less than the max.
  • Try to create a maximum below the minimum, ensure it autocorrects to one more then the minimum.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels May 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker force-pushed the issue-65913-inventory-legend-palettes branch 2 times, most recently from b3d4ef0 to 1ec74fe Compare May 19, 2020 11:27
@simianhacker simianhacker force-pushed the issue-65913-inventory-legend-palettes branch from 1ec74fe to 8776bd7 Compare May 19, 2020 14:39
@simianhacker simianhacker marked this pull request as ready for review May 19, 2020 16:44
@simianhacker simianhacker requested a review from a team as a code owner May 19, 2020 16:44
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simianhacker simianhacker merged commit 78db3ea into elastic:master May 21, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request May 21, 2020
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request May 21, 2020
simianhacker added a commit that referenced this pull request May 22, 2020
#67205)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sgrodzicki sgrodzicki added this to the Metrics UI 7.9 milestone May 26, 2020
@simianhacker simianhacker deleted the issue-65913-inventory-legend-palettes branch April 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Allow user to configure Waffle Map color palette
5 participants