Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #66984

Merged
merged 2 commits into from
May 27, 2020
Merged

Fix typos #66984

merged 2 commits into from
May 27, 2020

Conversation

yakryder
Copy link
Contributor

Summary

Found a small typo in an AppCategory doc comment.

Once I decided to correct it I figured I'd take a very brief glance over the rest of the repo. Doing so yielded two other tiny but unambiguous wins for language clarity.

This is my first contribution and I have deliberately kept it very simple. I read the CONTRIBUTING but I could have missed something.

Checklist

Thanks for making Kibana :)

@yakryder yakryder requested a review from a team as a code owner May 19, 2020 12:23
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented May 19, 2020 •
edited
Loading

💚 CLA has been signed

@timroes timroes added Team:Docs Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels May 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels May 19, 2020
@joshdover
Copy link
Contributor

joshdover commented May 19, 2020 •
edited
Loading

Hi there @Sherspock! You'll need to sign the CLA before you can contribute.

Also just a heads up, CI is going to fail on this. You'll need to run node scripts/check_published_api_changes.js --accept --docs --filter=core, commit + push those changes to get CI happy.

Once that's done I can kick off CI for you. Thanks for the contribution!

@joshdover joshdover self-assigned this May 19, 2020
@yakryder
Copy link
Contributor Author

@joshdover Thanks. My mistake on the CLA and doc generation. Both should now be resolved.

@yakryder
Copy link
Contributor Author

On a related note, kept running out of memory when running the doc generation task. Had to bump max-old-space-size to work around.

Not sure if there's an open issue -- a cursory search didn't reveal one.

@yakryder
Copy link
Contributor Author

@joshdover Just checking that there's nothing more to be done here. Both CLA and doc generation should have been handled a week ago

@pgayvallet
Copy link
Contributor

@elasticmachine merge upstream

pgayvallet
pgayvallet approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshdover
Copy link
Contributor

@elasticmachine retest

@joshdover
Copy link
Contributor

@Sherspock sorry for the delay! I'm going to go ahead and merge this, congrats on your first contribution to Kibana!

@joshdover joshdover merged commit 7071fac into elastic:master May 27, 2020
@joshdover joshdover mentioned this pull request May 27, 2020
Merged
joshdover pushed a commit to joshdover/kibana that referenced this pull request May 27, 2020
@yakryder @elasticmachine @joshdover
Fix typos (elastic#66984)
a194c61 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 29, 2020
@yakryder
Copy link
Contributor Author

Thanks! 🎉

@Sherspock sorry for the delay! I'm going to go ahead and merge this, congrats on your first contribution to Kibana!

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 2, 2020
joshdover added a commit that referenced this pull request Jun 2, 2020
@joshdover @yakryder @elasticmachine
[7.x] Fix typos (#66984) (#67550)
61d8950 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Ryder Timberlake <wrtimberlake@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

@joshdover joshdover

Labels
💝community release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yakryder @kibanamachine @elasticmachine @joshdover @pgayvallet @timroes