[APM] Fix obscured service map connections #67129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out from 0.85 -> 1.2
ogupte
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
May 20, 2020
sorenlouv
reviewed
May 20, 2020
| @@ -80,7 +80,7 @@ function getLayoutOptions( | |||
| roots: selectedRoots.length ? selectedRoots : undefined, | |||
| fit: true, | |||
| padding: nodeHeight, | |||
| spacingFactor: 0.85, | |||
| spacingFactor: 1.2, | |||
There was a problem hiding this comment.
Seems like a magic number but if it works...
There was a problem hiding this comment.
The docs for this setting (https://js.cytoscape.org/#layouts/breadthfirst) describe it as:
positive spacing factor, larger => more space between nodes
- also bump the label font size
nehaduggal
approved these changes
May 21, 2020
|
retest |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
May 21, 2020
* Closes elastic#67126 by increasing spacingFactor in the cytoscape layout from 0.85 -> 1.2 * - prevents labels from hiding when nodes get a bit smaller - also bump the label font size
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
May 21, 2020
* Closes elastic#67126 by increasing spacingFactor in the cytoscape layout from 0.85 -> 1.2 * - prevents labels from hiding when nodes get a bit smaller - also bump the label font size
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 21, 2020
* master: (21 commits) [Alerting] Hides the `alert` SavedObjects type (elastic#66719) skip flaky suite (elastic#66869) fix visual baseline tests [kbn/optimizer] require fsevents on macos (elastic#67147) [APM] Fix obscured service map connections (elastic#67129) [apm] Annotation API documentation (elastic#65963) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) ...
ogupte
added a commit
that referenced
this pull request
May 21, 2020
ogupte
added a commit
that referenced
this pull request
May 21, 2020
|
Looks good, on Chrome, FF and Safari. |
dgieselaar
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67126 by increasing
spacingFactorin the Cytoscape layout from 0.85 -> 1.2After (
spacingFactor: 1.2):Before (
spacingFactor: 0.85):