[kbn/optimizer] require fsevents on macos #67147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/certificates·ts.Uptime app with generated data certificates page "before each" hook for "performs search against monitor id"Standard OutStack TraceTo update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 21, 2020
* master: (21 commits) [Alerting] Hides the `alert` SavedObjects type (elastic#66719) skip flaky suite (elastic#66869) fix visual baseline tests [kbn/optimizer] require fsevents on macos (elastic#67147) [APM] Fix obscured service map connections (elastic#67129) [apm] Annotation API documentation (elastic#65963) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) ...
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten a number of reports over the last few months as people slowly upgrade to macOS Catalina that the
fseventsmodule is not being installed because of broken XCode installs. Since fsevents is technically an optional dependency bootstrap prints a warning and succeeds. It's easy to miss the warning, and hard to understand the relationship to the symptom.The issue is that when fsevents isn't available on macos webpack falls back to polling, which constantly reads all the files on the filesystem and quickly consumes a ton of system resources doing a whole lot of nothing. To fix the issue the steps at https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md should be followed, and then bootstrap should be run again.