Fix issue preventing KQL filters aggs with leading wildcards. #67227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:Aggregations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lukeelmers
commented
May 21, 2020
| @@ -67,8 +67,13 @@ export const filtersBucketAgg = new BucketAggType({ | |||
| return; | |||
| } | |||
|
|
|||
| const query = esQuery.buildEsQuery(aggConfig.getIndexPattern(), [input], [], config); | |||
There was a problem hiding this comment.
The problem was that config which was passed here is chrome.getUiSettingsClient(), instead of { allowLeadingWildcards: config.get('query:allowLeadingWildcards') }
So allowLeadingWildcards would default to false, and then fail when trying to parse the query.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mattkime
approved these changes
May 28, 2020
kibana-app-arch
automation
moved this from Review in progress
to Done in current release
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57828
Summary
This resolves an issue where KQL-based filters aggs in visualizations could fail in scenarios where leading wildcards are used, even when
query:allowLeadingWildcardsis set totrue.Opening a PR against the
7.6branch directly because this issue does not exist in7.7and later, that way this fix will be included should there be a7.6.3release. I have opened a separate PR with the added unit tests againstmaster, so that we can prevent future regressions.I was unable to pinpoint the exact root cause -- the code which fixed the problem has essentially remained unchanged since KQL was added to the filters agg back in
7.3. But one suspicion I have is that perhaps something changed related tobuildEsQuerywhen@kbn/es-querywas converted to typescript and moved todatain #51014, since this is one other major piece related to this functionality which was moved around in7.6Checklist