Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.search.aggs] Add unit tests for filters agg. #67229

Merged
merged 4 commits into from
May 28, 2020
Merged

[data.search.aggs] Add unit tests for filters agg. #67229

merged 4 commits into from
May 28, 2020

Conversation

lukeelmers
Copy link
Member

Adds unit tests for the bug fixed in #67227 in order to prevent future regressions.

@lukeelmers lukeelmers added chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v7.7.1 labels May 21, 2020
@lukeelmers lukeelmers requested a review from a team May 21, 2020 22:40
@lukeelmers lukeelmers self-assigned this May 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added this to Review in progress in kibana-app-arch May 21, 2020
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers lukeelmers mentioned this pull request May 26, 2020
Merged
1 task
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukeelmers lukeelmers merged commit 17573f1 into elastic:master May 28, 2020
kibana-app-arch automation moved this from Review in progress to Done in current release May 28, 2020
@lukeelmers lukeelmers deleted the fix/filters-tests branch May 28, 2020 14:48
@lukeelmers lukeelmers mentioned this pull request May 28, 2020
Merged
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request May 28, 2020
@lukeelmers
Add unit tests for filters agg. (elastic#67229)
68235f7
@lukeelmers lukeelmers mentioned this pull request May 28, 2020
Merged
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request May 28, 2020
@lukeelmers
Add unit tests for filters agg. (elastic#67229)
67db10f
@lukeelmers lukeelmers mentioned this pull request May 28, 2020
Merged
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request May 28, 2020
@lukeelmers
Add unit tests for filters agg. (elastic#67229)
8496529
lukeelmers added a commit that referenced this pull request May 28, 2020
@lukeelmers
Add unit tests for filters agg. (#67229) (#67626)
5007463
lukeelmers added a commit that referenced this pull request May 28, 2020
@lukeelmers
Add unit tests for filters agg. (#67229) (#67627)
57325e9
lukeelmers added a commit that referenced this pull request May 28, 2020
@lukeelmers
[7.7] Add unit tests for filters agg. (#67229) (#67628)
6c661f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees

@lukeelmers lukeelmers

Labels
chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:skip Skip the PR/issue when compiling release notes v7.7.1 v7.8.0 v7.9.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukeelmers @elasticmachine @kibanamachine @mattkime