chore(NA): avoids imports of server or public code into common #67231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
botelastic
bot
added
Feature:ExpressionLanguage
|
Pinging @elastic/apm-ui (Team:apm) |
mistic
removed
Feature:ExpressionLanguage
botelastic
bot
added
Feature:ExpressionLanguage
nreese
approved these changes
May 22, 2020
mistic
commented
May 22, 2020
...lugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx
Show resolved
Hide resolved
mistic
removed
Feature:ExpressionLanguage
rylnd
approved these changes
May 26, 2020
rylnd
reviewed
May 26, 2020
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
botelastic
bot
added
Feature:ExpressionLanguage
|
@elastic/kibana-app-arch @elastic/apm-ui @elastic/logs-metrics-ui @elastic/endpoint-app-team can I get a code owners review here please? 😃 |
smith
approved these changes
May 26, 2020
lizozom
approved these changes
May 29, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
oatkiller
approved these changes
Jun 2, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
7.x: cd79116 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jun 3, 2020
…ic#67231) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jun 3, 2020
…ic#67231) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> # Conflicts: # x-pack/plugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx # x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.d.ts # x-pack/plugins/security/common/licensing/license_service.test.ts # x-pack/plugins/spaces/common/licensing/license_service.test.ts
mistic
added a commit
that referenced
this pull request
Jun 3, 2020
… (#68168) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
mistic
added a commit
that referenced
this pull request
Jun 3, 2020
…67231) (#68175) * chore(NA): avoids imports of server or public code into common (#67231) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> # Conflicts: # x-pack/plugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx # x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.d.ts # x-pack/plugins/security/common/licensing/license_service.test.ts # x-pack/plugins/spaces/common/licensing/license_service.test.ts * chore(NA): fix eslint problems
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 4, 2020
…ms-column * 'master' of github.com:elastic/kibana: (63 commits) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) Update documentation/examples of deprecated namespaceAgnostic field (elastic#68039) [DOCS] Updates Canvas docs with new menus (elastic#66061) chore(NA): avoids imports of server or public code into common (elastic#67231) [SIEM] Fix GetOneTimeline graphql type (elastic#68137) skip flaky suite (elastic#67838) [Uptime] Add loading message for monitor list no items (elastic#67378) [Ingest Manager] Update indexing strategy docs to use dataset.* (elastic#68068) [Ingest Manager] Fix datasource validation for streams without vars (elastic#67950) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/index.ts # x-pack/plugins/index_management/__jest__/client_integration/home.test.ts # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a compliment to other PRs previously opened #67152 and #67149.
It adds an eslint rule to prevent
serverorpubliccode to be imported intocommoncode.