[Ingest Manager] Optimize installation of integration #67708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
reviewed
May 28, 2020
x-pack/plugins/ingest_manager/server/services/epm/packages/assets.ts
Outdated
Show resolved
Hide resolved
No, I was having some issues with server errors from APM working on your PR but noticed looking at the traces that this was a good place to start. Using chrome dev tools and looking at the time it takes for the integration install it usually cut the time significantly. |
|
@elasticmachine merge upstream |
jfsiii
approved these changes
Jun 1, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Jun 1, 2020
* call getArchiveInfo once first, pass paths to template * pass paths to installPreBuiltTemplates * pass paths to installILMPolicy * pass paths to ingest pipeline creation * use correct package key for cache * pass paths to kibana assets * cache other installed packages * create function for ensuring packages are cached * remove unused imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Jun 1, 2020
* call getArchiveInfo once first, pass paths to template * pass paths to installPreBuiltTemplates * pass paths to installILMPolicy * pass paths to ingest pipeline creation * use correct package key for cache * pass paths to kibana assets * cache other installed packages * create function for ensuring packages are cached * remove unused imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
neptunian
added a commit
that referenced
this pull request
Jun 1, 2020
* call getArchiveInfo once first, pass paths to template * pass paths to installPreBuiltTemplates * pass paths to installILMPolicy * pass paths to ingest pipeline creation * use correct package key for cache * pass paths to kibana assets * cache other installed packages * create function for ensuring packages are cached * remove unused imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
neptunian
added a commit
that referenced
this pull request
Jun 1, 2020
* call getArchiveInfo once first, pass paths to template * pass paths to installPreBuiltTemplates * pass paths to installILMPolicy * pass paths to ingest pipeline creation * use correct package key for cache * pass paths to kibana assets * cache other installed packages * create function for ensuring packages are cached * remove unused imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
@neptunian Could you elaborate on how / where exactly do we cache it? |
|
@ruflin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing an integration for a large package like AWS is timing out in cloud. I think this might speed things up enough.
Changes:
To test try the following on master and then in this PR:
*Note that because we use a cache it will take longer the first time its installed (which is going mostly always be the case) and whether or not other packages are installed (because of building the index patterns #67760 - i'm not comfortable making this optimization in alpha ) so these cases should be checked, too.
Fixes: #67743
Before changes, locally I consistently get about 7-9 seconds
With these changes its around 3-5
These comparisons were made by restarting the kibana server before each request so there was no cache of aws and while the default packages were installed only (base, endpoint, system)