[ML] DFAnalytics results: ensure ml result fields are shown in data grid #68305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
| @@ -110,7 +111,10 @@ export const getDataGridSchemasFromFieldTypes = (fieldTypes: FieldTypes, results | |||
| schema = 'numeric'; | |||
| } | |||
|
|
|||
| if (field.includes(`${resultsField}.${FEATURE_IMPORTANCE}`)) { | |||
| if ( | |||
There was a problem hiding this comment.
Is it possible to remove the ml.top_classes and ml.feature_importance leaf node fields from the data grid column picker modal e.g. ml.top_classes.class_name? Ideally we shouldn't let the user select the leaf nodes for display in the table as those columns will be blank:
alvarezmelissa87
force-pushed
the
ml-dfanalytics-blank-ml-cols
branch
from
e17963c
to
3324d71
Compare
|
The PR that removed the The removal of the |
peteharverson
approved these changes
Jun 8, 2020
peteharverson
added
release_note:skip
alvarezmelissa87
force-pushed
the
ml-dfanalytics-blank-ml-cols
branch
from
3324d71
to
000d61b
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Jun 8, 2020
Merged
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jun 8, 2020
…rid (elastic#68305) * wip: ensure top classes and influencer result col show up correctly * ensure ml subFields columns are populated
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jun 8, 2020
…rid (elastic#68305) * wip: ensure top classes and influencer result col show up correctly * ensure ml subFields columns are populated
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 8, 2020
* master: [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305) [security_solution] enable react-hooks/exhaustive-deps (elastic#68470) Closes elastic#66867 by adding missing, requried API params (elastic#68465) [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865) [Logs UI] View in context tweaks (elastic#67777) Kibana developer examples landing page (elastic#67049) Bump decompress package version (elastic#68386) fix elastic#66185 (elastic#66186) Bump pdfmake package version (elastic#68395) Unskip embeddables/adding_children suite (elastic#68111) Add embed mode options in the Share UI (elastic#58435) Adding key to avoid react warning (elastic#68491)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue of seeing blank
mlsubfield columns.ml.feature_importanceandml.top_classesare arrays of objects. The fields API used to create the columns incorrectly returns a path likeml.top_classes.class_namereferencing theclass_nameproperty in the object in the array. This leads to blank column values as dot paths can only be in nested objects.This PR fixes the issue by adding a
ml.top_classescolumn and correctly displaying the array of objects as the values. It also hides the blank path columns by default.This PR also ensures
ml.feature_importancecolumn shows up correctly.ml.top_classesml.feature_importanceChecklist
Delete any items that are not applicable to this PR.