run page_load_metrics tests in visual regresssion jobs #68570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
spalger
force-pushed
the
fix/page-load-metrics/run-in-baseline-job
branch
from
86534cf
to
9772a6f
Compare
spalger
commented
Jun 9, 2020
| @@ -11,8 +11,7 @@ mkdir -p "$installDir" | |||
| tar -xzf "$linuxBuild" -C "$installDir" --strip=1 | |||
|
|
|||
| echo " -> running visual regression tests from kibana directory" | |||
| checks-reporter-with-killswitch "X-Pack visual regression tests" \ | |||
There was a problem hiding this comment.
When this job is actually run in a PR it fails because of the -- --, there's apparently too many or not enough escapes or something to pass through the -- just to the percy exec call, which requires it... Since the visual regression stuff isn't currently run in PRs I just removed the checks reporter here.
|
Successful build with |
This reverts commit 9772a6f.
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
brianseeders
approved these changes
Jun 9, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jun 9, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jun 9, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Jun 9, 2020
spalger
added a commit
that referenced
this pull request
Jun 10, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to establish a baseline for every commit we must run the page_load_metrics "tests" on every commit to tracked branches. We do that by adding tasks to the visual baseline job, which has been repurposed a little bit to establish several different types of baseline (though we haven't renamed that job yet).