Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v24.1.0 #68141

Merged
merged 16 commits into from
Jun 9, 2020
Merged

Upgrade EUI to v24.1.0 #68141

merged 16 commits into from
Jun 9, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jun 3, 2020 •
edited
Loading

eui@23.3.1 ⏩ eui@24.1.0

  • New EuiColorPalettePicker component
  • Breaking API change in euiPaletteColorBlind
  • Changed the default palette of EUI_CHARTS_THEME_[LIGHT, DARK] themes
  • Deprecated EuiNavDrawer in favor of EuiCollapsibleNav
  • Improved EuiExpression

24.1.0

  • Added displayAsText prop to EuiDataGridColumn (#3520)
  • Added minSizeForControls prop to EuiDataGrid to control the minimum width for showing grid controls (#3527)
  • Passed getSelectedOptionForSearchValue to EuiComboBoxOptionsList as prop (#3501)
  • Added appendIconComponentCache function to allow manual pre-emptive loading of source elements into the EuiIcon cache (#3481)
  • Added initialSelected to EuiTableSelectionType properties to set initial selected checkboxes for EuiBasicTable (#3418)
  • Added exports for EuiSteps and related components types (#3471)
  • Added displayName to components using React.forwardRef (#3451)
  • Added event target checker for EuiOverlayMask's onClick prop (#3462)
  • Added EuiColorPalettePicker component (#3192)
  • Added left-start popover placement to EuiDatePicker (#3511)
  • Added theme prop to EuiHeader (#3524)
  • Added .euiHeaderLink-isActive class to EuiHeaderLink when isActive (#3524)
  • Added display, descriptionWidth, textWrap and isInvalid props to EuiExpression (#3467)
  • Added more exports for EuiColorPalettePicker types (#3542)

Bug Fixes

  • Fixed issue where multiple EuiToolTip components could be visible when element was focused (#3335)
  • Fixed EuiSuperSelect not rendering full width when isOpen is true (#3495)
  • Fixed EuiBasicTable shows no items if all items of last page is deleted (#3422)
  • Fixed TypeScript module name in generated eui_charts_theme.d.ts file (#3492)
  • Fixed code highlight color contrast in EuiCodeBlock (#3309)
  • Fixed regression in EuiComboBox not triggering its inputRef callback (#3532)

Deprecations

  • Added a deprecation notice for EuiNavDrawer family of components. Advise usage of EuiCollapsibleNav instead (#3487)

Notes

  • Removed src-framer files from the repository (#3487)

Theme: Amsterdam

  • Removed borders EuiModal (#3515)
  • Improve EuiOverlayMask colors (#3515)
  • Updated shadow styles to improve smoothness, use black as the base color, and deprecated opacity value of shadow mixins (#3428)
  • Removed borders from EuiFlyout and EuiPopover (#3477)
  • Updated EuiHeader and components (#3524)

24.0.0

  • Added null as acceptable icon prop for EuiCard (#3470)
  • Added sortBy and sortShift props to euiPaletteColorBlind() for sorting along the color wheel (#3387)
  • Added utcOffset prop to EuiSuperDatePicker (#3436)
  • Added partition key to EuiChartThemeType for Partition chart support (#3387)
  • Updated EuiImage's caption prop type from string to ReactNode (#3387)
  • Improved contrast for EuiCollapsibleNav close button (#3465)

Bug Fixes

  • Fixed EuiSuperDatePicker quick selection menu overriding specified time range with default values (#3446)
  • Fixed EuiCodeEditor console error when using the editor without import the default theme (#3454)
  • Fixed EuiDatePopoverContent onChange event to only accept string date input (#3460)

Breaking changes

  • Changed parameters for euiPaletteColorBlind() to an object (#3387)
  • Changed the default palette of EUI_CHARTS_THEME_LIGHT/DARK themes to the naturally sorted euiPaletteColorBlind() (#3387)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.9.0 labels Jun 3, 2020
@thompsongl
Copy link
Contributor Author

thompsongl commented Jun 3, 2020 •
edited
Loading

@cchaos Do you want to handle the euiPaletteColorBlind updates? I don't mind doing it, but you might have more insight.

Nevermind. Updates look simpler than expected. I'll tag you for review, though.

@thompsongl thompsongl requested a review from cchaos June 4, 2020 17:52
@thompsongl thompsongl marked this pull request as ready for review June 4, 2020 17:52
@thompsongl thompsongl requested review from a team as code owners June 4, 2020 17:52
nreese
nreese approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM
code review

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

spong
spong approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elastic Security (SIEM/Endpoint) changes LGTM! 👍

Reviewed code (just snapshots) & checked out and did a quick smoke test and all looks good. Thanks @thompsongl!

spalger
spalger approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed, but LGTM

test/functional/services/apps_menu.ts Outdated Show resolved Hide resolved
pgayvallet
pgayvallet approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for chrome snapshot changes

cchaos
cchaos approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search over the charts breaking changes, and we should be good!

@lizozom
Copy link
Contributor

lizozom commented Jun 8, 2020

@elasticmachine merge upstream

clintandrewhall
clintandrewhall approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G for Canvas. Thanks!

FrankHassanabad
FrankHassanabad approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Endpoint/SIEM side.

@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

smith
smith approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good! Thanks!

@thompsongl
Copy link
Contributor Author

Endpoint App Team review was an either/or with SIEM; @FrankHassanabad reviewed on their behalf.
Will merge on green

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit 0306c7a into elastic:master Jun 9, 2020
@thompsongl thompsongl mentioned this pull request Jun 9, 2020
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jun 9, 2020
@thompsongl @elasticmachine
Upgrade EUI to v24.1.0 (elastic#68141)
59f613e 
* eui to 24.1.0

* src snapshot updates

* x-pack snapshot updates

* euiPaletteColorBlind param updates

* euiPaletteColorBlind ts-ignore

* fix collapsibleNav close button click for functional testing

* await focus

* increase legacy sass build timeout value

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
thompsongl added a commit that referenced this pull request Jun 10, 2020
@thompsongl @elasticmachine
Upgrade EUI to v24.1.0 (#68141) (#68712)
7e7f446 
* eui to 24.1.0

* src snapshot updates

* x-pack snapshot updates

* euiPaletteColorBlind param updates

* euiPaletteColorBlind ts-ignore

* fix collapsibleNav close button click for functional testing

* await focus

* increase legacy sass build timeout value

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 10, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
86f7d73 
* master: (22 commits)
  Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624)
  adapt some snapshot test (elastic#68489)
  [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486)
  [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user
  [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294)
  Surface data streams in Index Management. (elastic#67806)
  Fix edit datasource not working following changes in elastic#67234 (elastic#68583)
  [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654)
  APM Storybook fixes (elastic#68671)
  Upgrade EUI to v24.1.0 (elastic#68141)
  [ML] DF Analytics: Creation wizard part 2 (elastic#68462)
  [Uptime] Fix race on overview page query (elastic#67843)
  Prefer using npm_execpath when spawning Yarn (elastic#68673)
  [Security] [Cases] Attach timeline to existing case (elastic#68580)
  Use Search API in Vega (elastic#68257)
  [Component templates] Table view (elastic#68031)
  [Uptime] Added relative date info in cert status column (elastic#67612)
  [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445)
  run page_load_metrics tests in visual regresssion jobs (elastic#68570)
  Enable exhaustive-deps; correct any lint warnings (elastic#68453)
  ...
@myasonik myasonik mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@nreese nreese nreese approved these changes

@cchaos cchaos cchaos approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@spalger spalger spalger approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@spong spong spong approved these changes

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet