Index Patterns Management - use /_resolve endpoint for data streams support

[mattkime]

Summary

Addresses #70271 #61368 #67329 #61368

• Index patterns management now uses the _/resolve/indices endpoint - Resolve index API elasticsearch#57626
• Can create index pattern against data streams and frozen indices
• Misc UI rendering improvements

Step 1 - define pattern

Before

After

Step 1 - matched items

Before

After

Step 2

Before

After

Useful commands for creating data streams. Create an index template, a data stream, and then add aa doc to create the index behind the data stream

PUT /_index_template/generic-logs
{
    "index_patterns": ["logs-*", "test_data_stream"],
    "template": {
        "mappings" : {
            "properties": {
                "@timestamp": {
                    "type": "date"
                }
            }
        }
    },
    "data_stream": {
        "timestamp_field": "@timestamp"
    }
}

PUT /_data_stream/test_data_stream

POST test_data_stream/_doc/
{
    "@timestamp" : "2020-10-10"
}

Create an alias

POST blogs/_doc/
{
    "user" : "matt",
    "message" : 20
}

POST /_aliases
{
    "actions" : [
        { "add" : { "index" : "blogs", "alias" : "alias1" } }
    ]
}

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[mattkime]

@elasticmachine merge upstream

[mdefazio]

UI design looks good! Thanks for making the edits!

[mattkime]

@elasticmachine merge upstream

[lukeelmers]

Tested locally (chrome macos), and it works great!

Added a few comments but code overall LGTM

[lukeelmers]

nit: Would be nice to use typeguards to differentiate between the different possible matchedItem.item types so that you don't need casting here.

Or perhaps make MatchedItem generic so that you can optionally specify an item type if it is known at compile time:

type MatchedItemTypes =
    | ResolveIndexResponseItemIndex
    | ResolveIndexResponseItemAlias
    | ResolveIndexResponseItemDataStream;

export interface MatchedItem<I extends MatchedItemTypes = MatchedItemTypes> {
  name: string;
  tags: Tag[];
  item: I;
}

// usage:
type MatchedDataStreamItem = MatchedItem<ResolveIndexResponseItemDataStream>;
export const canPreselectTimeField = (indices: MatchedDataStreamItem[]) => {}

[mattkime]

I just made the MatchedItem['item'] definition more flexible. I think the larger problem is that I'm trying to determine a specific type from a general type. It seems that typescript will allow me to write a function to do it but that seems like overkill just to check a single field. The best fix would be to track Data source items in their own array but I'd rather not make that change at this stage.

[lukeelmers]

Should we be debouncing this?

While testing locally I noticed that we are firing a new HTTP request on every keystroke, which can be a lot if you are typing a longer index pattern name.

To be clear, this behavior existed before this PR, but since we are updating related behavior here I wonder if it'd be worth throwing this in a lodash debounce

[mattkime]

I attempted this but the debounce functionality was becoming troublesome to implement since it was conflicting with the code that appends a *. I'll try to address in a separate PR. If nothing else, the calls to _resolve/indices are much more performant than running queries as the code previously did.

[lukeelmers]

Code changes LGTM, pending green build!

I did not retest in a browser to verify the pluralization changes, but the syntax looks correct AFAICT.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: e534d31

Build metrics

✅ unchanged

History

• 💔 Build #59587 failed 665daef
• 💔 Build #59569 failed d0e7d98
• 💚 Build #59226 succeeded 739f4ac
• 💔 Build #59186 failed 5a079f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[cjcenizal]

Looks like we got pinged due to a change in the rollup plugin, but the code in question pertains to index patterns. I'm going to approve without reviewing to dismiss the codeowner requirement.