Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing missing daily_model_snapshot_retention_after_days in job update schema #71086

Merged
merged 1 commit into from
Jul 8, 2020
Merged

[ML] Fixing missing daily_model_snapshot_retention_after_days in job update schema #71086

merged 1 commit into from
Jul 8, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 8, 2020 •
edited
Loading

Fixes issue when trying to edit a job in the Job Management page. The daily_model_snapshot_retention_after_days property should be present the job update schema.

Follows on from:
#65417
#69003

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 8, 2020 13:26
@jgowdyelastic jgowdyelastic self-assigned this Jul 8, 2020
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0 labels Jul 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

peteharverson
peteharverson approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit a861104 into elastic:master Jul 8, 2020
@jgowdyelastic jgowdyelastic deleted the fixing-missing-snapshot-retention-days-in-job-update-schema branch July 8, 2020 15:19
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 8, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 8, 2020
@jgowdyelastic
[ML] Fixing missing daily_model_snapshot_retention_after_days in job …
c1841ee 
…update schema (elastic#71086)
jgowdyelastic added a commit that referenced this pull request Jul 8, 2020
@jgowdyelastic
[ML] Fixing missing daily_model_snapshot_retention_after_days in job …
71134e4 
…update schema (#71086) (#71107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson