Migrated agg table karma tests to jest #71224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
VladLasitsa
added
Feature:NP Migration
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
alexwizp
reviewed
Jul 13, 2020
| $cellContent = $cell.find('[data-cell-content]'); | ||
| // in jest tests 'angular' is using jqLite. In jqLite the method find lookups only by tags. | ||
| // Because of this, we should change a way how we get cell content so that tests will pass. | ||
| $cellContent = angular.element($cell[0].querySelector('[data-cell-content]')); |
There was a problem hiding this comment.
as an alternative to your solution, we can use a not-so-popular tag (e.g. <section>) for an [data-cell-content] element
But I'm ok with this solution too
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Jul 13, 2020
* Migrated karma tests to jest * Add comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Jul 13, 2020
* Migrated karma tests to jest * Add comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57813
Summary
Migrated agg table karma tests to jest
Checklist
Delete any items that are not applicable to this PR.
For maintainers