Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index patterns on alias - reenable functional tests #71802

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Index patterns on alias - reenable functional tests #71802

merged 5 commits into from
Jul 23, 2020

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jul 15, 2020 •
edited
Loading

Fixing a flakey test - #59717

@mattkime mattkime linked an issue Jul 15, 2020 that may be closed by this pull request
Failing test: Chrome UI Functional Tests.test/functional/apps/management/_handle_alias·js - management Index patterns on aliases should be able to discover and verify no of hits for alias2 #59717
Closed
@mattkime mattkime changed the title reenable test Index patterns on alias - reenable functional tests Jul 15, 2020
@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime marked this pull request as ready for review July 23, 2020 22:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 v7.9.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 23, 2020
lukeelmers
lukeelmers approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code here LGTM, but maybe worth running the flaky test runner several times to make sure it's improving things?

@mattkime mattkime merged commit 5a1972b into elastic:master Jul 23, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Jul 23, 2020
@mattkime
Index patterns on alias - reenable functional tests (elastic#71802)
b133509 
* reenable test
* nav to management
@mattkime mattkime mentioned this pull request Jul 23, 2020
Merged
mattkime added a commit to mattkime/kibana that referenced this pull request Jul 23, 2020
@mattkime
Index patterns on alias - reenable functional tests (elastic#71802)
ac45aae 
* reenable test
* nav to management
@mattkime mattkime mentioned this pull request Jul 23, 2020
Merged
mattkime added a commit that referenced this pull request Jul 24, 2020
@mattkime
Index patterns on alias - reenable functional tests (#71802) (#73162)
60a9283 
* reenable test
* nav to management
mattkime added a commit that referenced this pull request Jul 24, 2020
@mattkime
Index patterns on alias - reenable functional tests (#71802) (#73163)
a3989ae 
* reenable test
* nav to management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@mattkime @kibanamachine @elasticmachine @lukeelmers