[Maps] auto-fit to data bounds #72129

nreese · 2020-07-16T18:36:24Z

Fixes #2054, #32738, #53831.

Continuation of #66452

This PR adds a new map setting that will auto fit the map to data bounds.

elasticmachine · 2020-07-16T18:36:46Z

Pinging @elastic/kibana-gis (Team:Geo)

jsanz · 2020-07-17T14:13:12Z

Tested locally on Firefox and Chromium and works perfectly for geo_point document, geo_shape, and agg layers (grid, cluster, and heatmap) layers. This is exciting!!

With EMS boundaries the behavior is inconsistent though, sometimes the view fits to the bounds, sometimes it does not. Feels like some issue with the synchronicity of events or something like that (very wild guess).

Finally, from the usability point of view, I think I would prefer a bit of a buffer between the data and the map borders, so instead of going exactly to the bounds, extending it a small fraction like 10% of the screen size or even less.

So instead of this

Zooming out a bit like this

nreese · 2020-07-17T16:22:39Z

@elasticmachine merge upstream

nreese · 2020-07-17T17:02:48Z

Finally, from the usability point of view, I think I would prefer a bit of a buffer between the data and the map borders, so instead of going exactly to the bounds, extending it a small fraction like 10% of the screen size or even less.

good suggestion, I added 10% scaling factor.

kmartastic · 2020-07-17T17:10:27Z

I think this behavior should be ON by default. Objections?

jsanz · 2020-07-17T17:25:13Z

I think this behavior should be ON by default. Objections?

I'm not 100% sure if this could be confusing for users since the Map Settings panel is pretty new. Would make sense to change somehow the Fit to data icon when this setting is enabled to visually highlight it and help users understand what's going on? Not strong on this either way.

nreese · 2020-07-17T19:30:12Z

With EMS boundaries the behavior is inconsistent though, sometimes the view fits to the bounds, sometimes it does not. Feels like some issue with the synchronicity of events or something like that (very wild guess).

There was a problem with join layers and auto fit to bounds. The original approach ran fit to bounds before fetching data for all layers. For non-join layers, this is preferred because you want the new bounds before fetching data. However, this breaks join layers because join layers live on the client so they need re-freshed data before you can run fit to bounds.

I have updated the logic to syncData for join layers prior to running fit to bounds. This fixes the issue you saw with EMS boundary layers.

nreese · 2020-07-17T20:54:52Z

I think this behavior should be ON by default. Objections?

moving discussion to #72340

Would make sense to change somehow the Fit to data icon when this setting is enabled to visually highlight it and help users understand what's going on?

moving discussion to #72341

Both are great questions. I would like to move them into there own threads and avoid discussion in this PR. Once the basic feature is merged, we can discuss these as needed but I do not want to block/distract the basic feature for these non-essential elements.

nreese · 2020-07-17T22:32:13Z

@elasticmachine merge upstream

nickpeihl

lgtm! I love it.

tested in Chrome.

jsanz

tested again with EMS boundaries and working fine, thanks for opening the new issues for further discussion 👍

nreese · 2020-07-20T13:32:26Z

@elasticmachine merge upstream

nreese · 2020-07-20T13:33:11Z

What should the interaction be with the initial map view and auto fit to bounds? Should the map auto fit to bounds when first opened? Or respect the initial view setting?

kmartastic · 2020-07-20T15:15:57Z

@nreese Can you explain the initial view setting to me? Is this a user setting?

nreese · 2020-07-20T15:38:04Z

Can you explain the initial view setting to me? Is this a user setting?

Users can configure the initial location of the map to be the location at save, a fixed location, or a browser location. Should auto fit to bounds effect this choice? When auto fit to bounds is enabled, should the initial map location use this setting or the fit to the data bounds?

kmartastic · 2020-07-20T15:49:55Z

Can you explain the initial view setting to me? Is this a user setting?

Users can configure the initial location of the map to be the location at save, a fixed location, or a browser location. Should auto fit to bounds effect this choice? When auto fit to bounds is enabled, should the initial map location use this setting or the fit to the data bounds?

We should honor this setting on initial load of the map.

…uto_fit_to_bounds2

nreese · 2020-07-20T16:52:33Z

We should honor this setting on initial load of the map.

Sounds like the consensus is that "auto fit to bounds" should be an independent setting from "initial map location". I like this choice because it gives users the greatest flexibly to configure their mapping experience. I have opened #72480 to track adding "fit to data bounds" under "initial map location" so users have the ability to open maps to data bounds.

Since this PR preserves the behavior of initial map location, it can merge as is and #72480 will address initial map location with regards to fit to bounds

kibanamachine · 2020-07-20T21:17:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: db8c9af

Build metrics

async chunks size

id	value	diff	baseline
maps	3.8MB	+2.3KB	3.8MB

History

💔 Build #63040 failed 760ea77
💔 Build #62956 failed 79a3760
💚 Build #62782 succeeded a5c33d4
💚 Build #62783 succeeded 5a34d64
💔 Build #62744 failed 4052774

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Maps] auto-fit to data bounds * update jest snapshot * add buffer to fit to bounds * sync join layers prior to fitting to bounds * clean-up comment * better names * fix tslint errors * update functional test expect * add functional tests * clean-up * change test run location * fix test expect Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [Maps] auto-fit to data bounds * update jest snapshot * add buffer to fit to bounds * sync join layers prior to fitting to bounds * clean-up comment * better names * fix tslint errors * update functional test expect * add functional tests * clean-up * change test run location * fix test expect Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (28 commits) allow some env settings for ingest manager (elastic#72544) Add inspector for VEGA (elastic#70941) chore(NA): fix grunt task for test:coverage (elastic#72539) Archive e2e test results in ES (elastic#72575) preserve 401 errors from new es client (elastic#71248) [SIEM][Detections] Updates text for severity and risk_score overrides (elastic#72244) fixing error occurences tooltip (elastic#72425) use KibanaClient interface instead of Client for new client interface (elastic#72388) [APM] Handle ML errors (elastic#72316) [Discover] Improve histogram tests (elastic#72235) [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540) [pre-req] Move .storybook to storybook; standardize files (elastic#72384) [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538) [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468) [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336) [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509) Fix long combo box items breaking out of flex item width (elastic#72512) [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366) [Security Solution][Resolver] Update the resolver element ref on scroll events if the position of the element has changed within the page (elastic#72461) [Maps] auto-fit to data bounds (elastic#72129) ...

[Maps] auto-fit to data bounds

8a2517e

nreese requested a review from a team as a code owner July 16, 2020 18:36

nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.10.0 v8.0.0 WIP Work in progress labels Jul 16, 2020

nreese mentioned this pull request Jul 16, 2020

[Maps] auto-fit to data bounds #66452

Closed

elasticmachine and others added 3 commits July 17, 2020 10:22

Merge branch 'master' into auto_fit_to_bounds2

6811231

update jest snapshot

0eade40

add buffer to fit to bounds

94dc127

nreese added 2 commits July 17, 2020 13:23

sync join layers prior to fitting to bounds

4a0b500

clean-up comment

339d59f

nreese added 2 commits July 17, 2020 13:32

better names

37e821b

fix tslint errors

4052774

nreese mentioned this pull request Jul 17, 2020

[Maps] Should auto fit to bounds be enabled by default? #72340

Closed

update functional test expect

a5c33d4

Merge branch 'master' into auto_fit_to_bounds2

5a34d64

nickpeihl approved these changes Jul 18, 2020

View reviewed changes

jsanz approved these changes Jul 20, 2020

View reviewed changes

add functional tests

6acba76

clean-up

0f78615

Merge branch 'master' into auto_fit_to_bounds2

79a3760

nreese removed the WIP Work in progress label Jul 20, 2020

change test run location

d44c65f

nreese mentioned this pull request Jul 20, 2020

[Maps] add initial location option that fits to data bounds #72480

Closed

Merge branch 'auto_fit_to_bounds2' of github.com:nreese/kibana into a…

760ea77

…uto_fit_to_bounds2

fix test expect

db8c9af

nreese merged commit 9947c67 into elastic:master Jul 20, 2020

nreese mentioned this pull request Jul 20, 2020

[Maps] Auto adjust map center and zoom when filtering map #53831

Closed

nreese mentioned this pull request Jul 20, 2020

[7.x] [Maps] auto-fit to data bounds (#72129) #72536

Merged

nreese mentioned this pull request Dec 18, 2020

Enhancement Request on Embedded Maps in Canvas #61440

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] auto-fit to data bounds #72129

[Maps] auto-fit to data bounds #72129

nreese commented Jul 16, 2020 •

edited

Loading

elasticmachine commented Jul 16, 2020

jsanz commented Jul 17, 2020

nreese commented Jul 17, 2020

nreese commented Jul 17, 2020

kmartastic commented Jul 17, 2020

jsanz commented Jul 17, 2020

nreese commented Jul 17, 2020 •

edited

Loading

nreese commented Jul 17, 2020 •

edited

Loading

nreese commented Jul 17, 2020

nickpeihl left a comment

jsanz left a comment

nreese commented Jul 20, 2020

nreese commented Jul 20, 2020

kmartastic commented Jul 20, 2020

nreese commented Jul 20, 2020 •

edited

Loading

kmartastic commented Jul 20, 2020

nreese commented Jul 20, 2020 •

edited

Loading

kibanamachine commented Jul 20, 2020

[Maps] auto-fit to data bounds #72129

[Maps] auto-fit to data bounds #72129

Conversation

nreese commented Jul 16, 2020 • edited Loading

elasticmachine commented Jul 16, 2020

jsanz commented Jul 17, 2020

nreese commented Jul 17, 2020

nreese commented Jul 17, 2020

kmartastic commented Jul 17, 2020

jsanz commented Jul 17, 2020

nreese commented Jul 17, 2020 • edited Loading

nreese commented Jul 17, 2020 • edited Loading

nreese commented Jul 17, 2020

nickpeihl left a comment

Choose a reason for hiding this comment

jsanz left a comment

Choose a reason for hiding this comment

nreese commented Jul 20, 2020

nreese commented Jul 20, 2020

kmartastic commented Jul 20, 2020

nreese commented Jul 20, 2020 • edited Loading

kmartastic commented Jul 20, 2020

nreese commented Jul 20, 2020 • edited Loading

kibanamachine commented Jul 20, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

nreese commented Jul 16, 2020 •

edited

Loading

nreese commented Jul 17, 2020 •

edited

Loading

nreese commented Jul 17, 2020 •

edited

Loading

nreese commented Jul 20, 2020 •

edited

Loading

nreese commented Jul 20, 2020 •

edited

Loading