Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solutions] Add tooltips (#73436) #73627

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

andrew-goldstein
Copy link
Contributor

Backports the following commits to 7.x:

## Summary

This PR adds three tooltips. The first two are tooltips for the `attaching to a case` buttons. The third tooltip is for the `Upload value lists` button in the `Detections` page.

**Timeline:**
<img width="672" alt="Screenshot 2020-07-28 at 3 08 31 PM" src="https://user-images.githubusercontent.com/7871006/88664558-e79aee00-d0e5-11ea-9644-48480c194498.png">

<img width="673" alt="Screenshot 2020-07-28 at 3 08 38 PM" src="https://user-images.githubusercontent.com/7871006/88664552-e49ffd80-d0e5-11ea-8d9e-2910f58332d4.png">

**Detections:**

<img width="639" alt="Screenshot 2020-07-28 at 3 19 53 PM" src="https://user-images.githubusercontent.com/7871006/88664531-dce05900-d0e5-11ea-9dcd-7e336f215e40.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@andrew-goldstein
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +1.5KB 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 9ed8227 into elastic:7.x Jul 29, 2020
@andrew-goldstein andrew-goldstein deleted the backport/7.x/pr-73436 branch July 29, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants