Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add layer type preview icons #78650

Merged
merged 2 commits into from Sep 29, 2020

Conversation

miukimiu
Copy link
Contributor

Summary

Closes #70266.

This PR is an enhancement for some of the add layer wizard icons.

Maps icons@2x

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@miukimiu miukimiu added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Sep 28, 2020
@miukimiu miukimiu requested review from a team as code owners September 28, 2020 17:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
maps 741 +5 736

async chunks size

id value diff baseline
maps 3.3MB +14.8KB 3.3MB

page load bundle size

id value diff baseline
maps 159.4KB +656.0B 158.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thx!

@cchaos cchaos added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Sep 29, 2020
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice looking! 😍 And so much more helpful than the Elasticsearch logo 😆

@miukimiu miukimiu merged commit 895eb09 into elastic:master Sep 29, 2020
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
…-to-timeline

* 'master' of github.com:elastic/kibana: (22 commits)
  update apm index pattern (elastic#78732)
  78024: move transform out of dataset (elastic#78216)
  [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695)
  [Discover] Make _source field not clickable (elastic#78698)
  [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685)
  [APM] Review feedback from distribution + transaction metrics (elastic#78752)
  [Ingest pipelines] Add ability to stop pipeline simulation  (elastic#78183)
  [CSM] Fix core vital legend background (elastic#78273)
  [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481)
  fix lodash imports (elastic#78456)
  [Maps] Add layer type preview icons (elastic#78650)
  [APM] Use transaction metrics for distribution charts (elastic#78484)
  [Uptime] Ml anomaly alert edit (elastic#76909)
  [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78650 or prevent reminders by adding the backport:skip label.

nreese pushed a commit to nreese/kibana that referenced this pull request Oct 1, 2020
* Added layer type preview icons

* Added margin tops
@nreese
Copy link
Contributor

nreese commented Oct 1, 2020

7.x/7.10 #79104

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
nreese added a commit that referenced this pull request Oct 1, 2020
* Added layer type preview icons

* Added margin tops

Co-authored-by: Elizabet Oliveira <elizabet.oliveira@gmail.com>
@kmartastic kmartastic mentioned this pull request Nov 2, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Provide preview-icons of layer-type
6 participants