[CI] Preparation for APM tracking on CI #80399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
commented
Oct 13, 2020
| @@ -41,13 +41,13 @@ const getDefaultConfig = (isDistributable: boolean): ApmAgentConfig => { | |||
|
|
|||
| return { | |||
| active: false, | |||
| serverUrl: 'https://f1542b814f674090afd914960583265f.apm.us-central1.gcp.cloud.es.io:443', | |||
| serverUrl: 'https://b1e3b4b4233e44cdad468c127d0af8d8.apm.europe-west1.gcp.cloud.es.io:443', | |||
There was a problem hiding this comment.
This location doesn't seem ideal as I believe our CI workers are in U.S. West. We can move it if it ends up being an issue.
tylersmalley
force-pushed
the
enable-apm-ci
branch
4 times, most recently
from
c430bae
to
0d57811
Compare
This comment has been minimized.
This comment has been minimized.
tylersmalley
force-pushed
the
enable-apm-ci
branch
7 times, most recently
from
c6166a3
to
9bff89c
Compare
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 21, 2020
This is being used in other click* helpers, but was missing here. Resulting in failures in elastic#80399 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
Oct 21, 2020
This is being used in other click* helpers, but was missing here. Resulting in failures in #80399 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 21, 2020
This is being used in other click* helpers, but was missing here. Resulting in failures in elastic#80399 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
enable-apm-ci
branch
from
ba4d805
to
6f0f663
Compare
tylersmalley
commented
Oct 21, 2020
| @@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { | |||
| const browser = getService('browser'); | |||
| const queryBar = getService('queryBar'); | |||
|
|
|||
| describe('Endpoint Event Resolver', function () { | |||
| describe.skip('Endpoint Event Resolver', function () { | |||
There was a problem hiding this comment.
@IgorGuz2000, I see you have worked with these tests quite a bit recently. Would you mind helping me resolving the failures here caused by enabling APM on the project?
To reproduce:
export ELASTIC_APM_ACTIVE=true
node scripts/functional_tests_server.js --config x-pack/test/security_solution_endpoint/config.ts
node scripts/functional_test_runner.js --config x-pack/test/security_solution_endpoint/config.ts --grep "Endpoint Event Resolver"
So far the failures I have been able to address have been timing related.
1) endpoint
Endpoint Event Resolver
Endpoint Resolver Tree
Check Related Events for event.file Node:
Error: expected '1 registry' to equal 'Events'
at Assertion.assert (packages/kbn-expect/expect.js:100:11)
at Assertion.equal (packages/kbn-expect/expect.js:227:8)
at Object.runNodeEvents (x-pack/test/security_solution_endpoint/page_objects/hosts_page.ts:127:30)
at process._tickCallback (internal/process/next_tick.js:68:7)
2) endpoint
Endpoint Event Resolver
Resolver Tree events
Check Related Events for event.process Node:
Error: expected '60 registry' to equal 'Events'
at Assertion.assert (packages/kbn-expect/expect.js:100:11)
at Assertion.equal (packages/kbn-expect/expect.js:227:8)
at Object.runNodeEvents (x-pack/test/security_solution_endpoint/page_objects/hosts_page.ts:127:30)
at process._tickCallback (internal/process/next_tick.js:68:7)
3) endpoint
Endpoint Event Resolver
Resolver Tree events
Check Related Events for event.library Node:
Error: expected '1 library' to equal 'Events'
at Assertion.assert (packages/kbn-expect/expect.js:100:11)
at Assertion.equal (packages/kbn-expect/expect.js:227:8)
at Object.runNodeEvents (x-pack/test/security_solution_endpoint/page_objects/hosts_page.ts:127:30)
at process._tickCallback (internal/process/next_tick.js:68:7)
b1a6f18
to
af7f0bd
Compare
tylersmalley
pushed a commit
that referenced
this pull request
Oct 21, 2020
tylersmalley
force-pushed
the
enable-apm-ci
branch
from
af7f0bd
to
55fe467
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
enable-apm-ci
branch
from
55fe467
to
180362b
Compare
tylersmalley
changed the title
tylersmalley
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/kibana-platform (Team:Platform) |
spalger
added
the
release_note:skip
spalger
reviewed
Oct 26, 2020
spalger
approved these changes
Oct 26, 2020
pgayvallet
approved these changes
Oct 26, 2020
8 tasks
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 26, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
Oct 27, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 27, 2020
* master: (37 commits) [ILM] Migrate Warm phase to Form Lib (elastic#81323) [Security Solutions][Detection Engine] Fixes critical bug with error reporting that was doing a throw (elastic#81549) [Detection Rules] Add 7.10 rules (elastic#81676) [kbn/optimizer] ignore missing metrics when updating limits with --focus (elastic#81696) [SECURITY SOLUTIONS] Bugs overview page + investigate eql in timeline (elastic#81550) [Maps] fix unable to edit cluster vector styles styled by count when switching to super fine grid resolution (elastic#81525) Fixed migration issue for case specific actions, by extending email action migrator checks (elastic#81673) [CI] Preparation for APM tracking on CI (elastic#80399) [Home] Fixes Kibana app description order on home page and updates Canvas copy (elastic#80057) Make sure `to` is 'now' and not the same as `from` (elastic#81524) Nitpicking the 8.0 Breaking Change issue template (elastic#81678) [SECURITY_SOLUTION] Fix text on onboarding screen (elastic#81672) [data.search] Skip async search tests in build candidates and production builds (elastic#81547) Fix previousStartedAt by not changing when execution fails (elastic#81388) [Monitoring] Fix a couple of issues with the cpu usage alert (elastic#80737) Telemetry collection xpack to ts project references (elastic#81269) Elasticsearch: don't use url authentication for new client (elastic#81564) [App Search] Credentials: implement working flyout form (elastic#81541) Properly encode links to edit user page (elastic#81562) [Alerting UI] Don't wait for health check before showing Create Alert flyout (elastic#80996) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates default APM server/token with that of the Kibana Stats cluster and enable APM on CI.
There are still tests that are failing that need addressed. It will be easier for others to assist with when this is available in master.
To enable set
ELASTIC_APM_ACTIVE=true