[Monitoring] Fix a couple of issues with the cpu usage alert #80737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:fix
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
igoristic
suggested changes
Oct 26, 2020
| } else { | ||
| cpuUsage = stat.cpuUsage; | ||
| stat.cpuUsage = stat.cpuUsage; | ||
| } |
There was a problem hiding this comment.
I don't think you need this else clause here
chrisronline
force-pushed
the
monitoring/cpu_usage_fixes
branch
from
16b6225
to
5dc3d18
Compare
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 26, 2020
…#80737) * Fix a couple of issues with the cpu usage alert * Fix tests * PR feedback # Conflicts: # x-pack/plugins/monitoring/public/components/elasticsearch/node/advanced.js
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 26, 2020
…#80737) * Fix a couple of issues with the cpu usage alert * Fix tests * PR feedback # Conflicts: # x-pack/plugins/monitoring/public/components/elasticsearch/node/advanced.js
chrisronline
added a commit
that referenced
this pull request
Oct 26, 2020
chrisronline
added a commit
that referenced
this pull request
Oct 26, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 27, 2020
* master: (37 commits) [ILM] Migrate Warm phase to Form Lib (elastic#81323) [Security Solutions][Detection Engine] Fixes critical bug with error reporting that was doing a throw (elastic#81549) [Detection Rules] Add 7.10 rules (elastic#81676) [kbn/optimizer] ignore missing metrics when updating limits with --focus (elastic#81696) [SECURITY SOLUTIONS] Bugs overview page + investigate eql in timeline (elastic#81550) [Maps] fix unable to edit cluster vector styles styled by count when switching to super fine grid resolution (elastic#81525) Fixed migration issue for case specific actions, by extending email action migrator checks (elastic#81673) [CI] Preparation for APM tracking on CI (elastic#80399) [Home] Fixes Kibana app description order on home page and updates Canvas copy (elastic#80057) Make sure `to` is 'now' and not the same as `from` (elastic#81524) Nitpicking the 8.0 Breaking Change issue template (elastic#81678) [SECURITY_SOLUTION] Fix text on onboarding screen (elastic#81672) [data.search] Skip async search tests in build candidates and production builds (elastic#81547) Fix previousStartedAt by not changing when execution fails (elastic#81388) [Monitoring] Fix a couple of issues with the cpu usage alert (elastic#80737) Telemetry collection xpack to ts project references (elastic#81269) Elasticsearch: don't use url authentication for new client (elastic#81564) [App Search] Credentials: implement working flyout form (elastic#81541) Properly encode links to edit user page (elastic#81562) [Alerting UI] Don't wait for health check before showing Create Alert flyout (elastic#80996) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80689
Resolves #80684
@ravikesarwani found a couple issues with the CPU alert and this PR aims to address both of them.
First, we discovered that the
Node -> Advancedpage wasn't properly filtering out alert instances for other nodes.Second, the way we calculate container CPU utilization didn't match what we are doing for the CPU utilization chart, which is actually more accurate. A couple of the data points are running counters (usage and periods cgroup data) and need to be treated as such, by using a derivative to properly use them. In order to use a derivative, we need to use a
date_histogrameven though we have no need for multiple buckets, we just need them to properly calculate the derivative so we are using afixed_intervalset to the same time range as thedurationparameter of the alert (which is also used in the same query in arangefilter)