removing `kibana_datatable` in favor of `datatable` #80548

ppisljar · 2020-10-14T15:57:15Z

Summary

Removes kibana_datatable and makes all expression functions/renderers use same format of datatable

followup:

reopens #75184, meta params are now removed from serialized field format.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…able2

# Conflicts: # src/plugins/vis_type_table/public/table_vis_fn.ts

elasticmachine · 2020-10-14T15:59:25Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

ppisljar · 2020-10-14T18:13:12Z

@elasticmachine merge upstream

lukeelmers

Overall code LGTM here (I focused mainly on the app arch files and briefly reviewed the rest).

I updated the baselines for the interpreter functional tests, and as usual there are a few weird things in the screengrabs. Specifically:

test/interpreter_functional/screenshots/baseline/metric_invalid_data.png

It feels like we had the wrong baseline here originally, as the added one from this PR looks like what I would expect.

test/interpreter_functional/screenshots/baseline/partial_test_3.png

Map controls are now missing from this screengrab, not sure why?

Also on all of the screengrabs, the dimensions changed slightly after running on my machine. Not sure if this is correct; I guess we can wait and see if they pass.

Based on how finicky the screengrabs have been historically, I think we should continue to avoid adding new ones and prefer the snapshots instead whenever possible.

lukeelmers · 2020-10-15T17:49:40Z

src/plugins/data/public/actions/filters/create_filters_from_range_select.ts

+  const { indexPatternId, ...aggConfigs } = column.meta.sourceParams;
+  const indexPattern = await getIndexPatterns().get(indexPatternId);
+  const aggConfigsInstance = getSearchService().aggs.createAggConfigs(indexPattern, [
+    aggConfigs as AggConfigSerialized,


So I guess we need to cast here because the only constraints on the sourceParams is that it's serializable?

Maybe down the road we could look into introducing more specific typings for different sources. So that someone could do something like:

column.meta.sourceParams as EsaggsDatatableSourceParams

I guess this doesn't matter a ton though with the plan of moving toward utility functions, as most folks won't need to worry about these types at all.

kibanamachine · 2020-10-15T20:24:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0688ec2

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`data`	568	566	-2
`expressions`	105	104	-1
total			-3

async chunks size

id	before	after	diff
`lens`	1.0MB	1.0MB	-37.0B

distributable file count

id	before	after	diff
`default`	48493	48492	-1
`oss`	29211	29210	-1

page load bundle size

id	before	after	diff
`data`	1.1MB	1.1MB	+1.7KB
`expressions`	198.5KB	196.2KB	-2.3KB
`lens`	79.8KB	79.8KB	+65.0B
`regionMap`	49.9KB	49.9KB	-7.0B
`tileMap`	49.2KB	49.2KB	+5.0B
`urlDrilldown`	18.7KB	18.4KB	-370.0B
`visTypeMarkdown`	15.5KB	15.5KB	+18.0B
`visTypeMetric`	27.1KB	27.1KB	+11.0B
`visTypeTable`	20.2KB	20.1KB	-7.0B
`visTypeTagcloud`	22.0KB	22.1KB	+8.0B
`visTypeTimelion`	36.1KB	36.1KB	+18.0B
`visTypeVislib`	222.5KB	222.5KB	-14.0B
`visualizations`	272.2KB	272.2KB	+62.0B
total			-749.0B

History

💔 Build #81719 failed cfd3742
💔 Build #81718 failed d54799c
💔 Build #81677 failed 0e20ca0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293

Tested and still seems to work fine in Lens

crob611

Canvas changes look good 👍

lukeelmers

I guess the updated baselines worked! Code LGTM

* master: (43 commits) [ML] Transforms: Fix tab ids for expanded row. (elastic#80666) server logs config paths to use for runner (elastic#52980) Fix audit logger logging to console even when disabled (elastic#80928) skip flaky suite (elastic#80929) Added Enterprise Search config to kibana-docker (elastic#80872) skip flaky suite (elastic#80914) [keystore_cli] parse values as JSON before adding to keystore (elastic#80848) [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742) ECS audit logging (elastic#74640) [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215) [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854) Move renderHeaderActions back into mount useEffect + update tests (elastic#80861) [Reporting] Document Network Policy configuration (elastic#80431) [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782) Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757) [Actions] Back Button on Add Connector Flyout (elastic#80160) removing `kibana_datatable` in favor of `datatable` (elastic#80548) [Alerting UI] Updating 'Add new' wording (elastic#80509) [Docs] Document Encrypted Saved Objects functionality. (elastic#80183) [Discover] fix auto-refresh (elastic#80635) ...

* master: (23 commits) [ML] Transforms: Fix tab ids for expanded row. (elastic#80666) server logs config paths to use for runner (elastic#52980) Fix audit logger logging to console even when disabled (elastic#80928) skip flaky suite (elastic#80929) Added Enterprise Search config to kibana-docker (elastic#80872) skip flaky suite (elastic#80914) [keystore_cli] parse values as JSON before adding to keystore (elastic#80848) [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742) ECS audit logging (elastic#74640) [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215) [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854) Move renderHeaderActions back into mount useEffect + update tests (elastic#80861) [Reporting] Document Network Policy configuration (elastic#80431) [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782) Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757) [Actions] Back Button on Add Connector Flyout (elastic#80160) removing `kibana_datatable` in favor of `datatable` (elastic#80548) [Alerting UI] Updating 'Add new' wording (elastic#80509) [Docs] Document Encrypted Saved Objects functionality. (elastic#80183) [Discover] fix auto-refresh (elastic#80635) ...

ppisljar and others added 19 commits September 29, 2020 00:04

removing kibana_datatable

b3612d4

updating

e93e530

fixing

c281334

fixing

436f977

fixes

9453941

Merge remote-tracking branch 'origin/master' into HEAD

c25ef8f

Update docs

f9c5074

Fix tests

b8458f6

fix url drilldown field retrieval

283bd1b

Merge remote-tracking branch 'upstream/master' into expressions/datat…

e475daa

…able2

fix test in the right direction

7e827bd

update snapshots

03ca92a

fix snapshots

b9e4287

Merge branch 'master' into expressions/datatable2

71a4b57

# Conflicts: # src/plugins/vis_type_table/public/table_vis_fn.ts

catching the error on renderer and displaying it

2888c75

emitting done when no data inside visualization container

0090a06

adding comments

77f0367

fixing lens regression

df06935

removing meta params from serialized field format

d7fb5de

ppisljar requested a review from a team October 14, 2020 15:57

ppisljar requested review from a team as code owners October 14, 2020 15:57

botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Oct 14, 2020

ppisljar added release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.11.0 and removed Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame labels Oct 14, 2020

ppisljar added the v8.0.0 label Oct 14, 2020

ppisljar changed the title ~~Expressions/datatable2~~ removing kibana_datatable in favor of datatable` Oct 14, 2020

ppisljar changed the title ~~removing kibana_datatable in favor of datatable`~~ removing kibana_datatable in favor of datatable Oct 14, 2020

botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame labels Oct 14, 2020

ppisljar added 2 commits October 14, 2020 11:11

updating snapshots

c51a98f

fixing type

d54799c

ppisljar force-pushed the expressions/datatable2 branch from 0e20ca0 to d54799c Compare October 14, 2020 18:13

kibanamachine and others added 2 commits October 14, 2020 14:13

Merge branch 'master' into expressions/datatable2

cfd3742

Update test baselines.

0688ec2

lukeelmers reviewed Oct 15, 2020

View reviewed changes

flash1293 approved these changes Oct 16, 2020

View reviewed changes

flash1293 mentioned this pull request Oct 16, 2020

Offer functions to work with data table column meta data #80820

Closed

crob611 approved these changes Oct 16, 2020

View reviewed changes

lukeelmers approved these changes Oct 16, 2020

View reviewed changes

ppisljar merged commit c90daba into elastic:master Oct 16, 2020

ppisljar mentioned this pull request Oct 16, 2020

[7.x] removing kibana_datatable in favor of datatable (#80548) #80875

Merged

ppisljar added a commit to ppisljar/kibana that referenced this pull request Oct 16, 2020

removing kibana_datatable in favor of datatable (elastic#80548)

f105c68

ppisljar added a commit that referenced this pull request Oct 16, 2020

removing kibana_datatable in favor of datatable (#80548) (#80875)

d25c84f

Dosant mentioned this pull request May 4, 2021

Kibana URL field in index-pattern with relative URL stores the base URL at creation time in the saved object #63924

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removing `kibana_datatable` in favor of `datatable` #80548

removing `kibana_datatable` in favor of `datatable` #80548

ppisljar commented Oct 14, 2020 •

edited

Loading

elasticmachine commented Oct 14, 2020

ppisljar commented Oct 14, 2020

lukeelmers left a comment

lukeelmers Oct 15, 2020

lukeelmers Oct 16, 2020

kibanamachine commented Oct 15, 2020

flash1293 left a comment

crob611 left a comment

lukeelmers left a comment

removing kibana_datatable in favor of datatable #80548

removing kibana_datatable in favor of datatable #80548

Conversation

ppisljar commented Oct 14, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 14, 2020

ppisljar commented Oct 14, 2020

lukeelmers left a comment

Choose a reason for hiding this comment

lukeelmers Oct 15, 2020

Choose a reason for hiding this comment

lukeelmers Oct 16, 2020

Choose a reason for hiding this comment

kibanamachine commented Oct 15, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

distributable file count

page load bundle size

History

flash1293 left a comment

Choose a reason for hiding this comment

crob611 left a comment

Choose a reason for hiding this comment

lukeelmers left a comment

Choose a reason for hiding this comment

removing `kibana_datatable` in favor of `datatable` #80548

removing `kibana_datatable` in favor of `datatable` #80548

ppisljar commented Oct 14, 2020 •

edited

Loading