Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer functions to work with data table column meta data #80820

Closed
flash1293 opened this issue Oct 16, 2020 · 4 comments
Closed

Offer functions to work with data table column meta data #80820

flash1293 opened this issue Oct 16, 2020 · 4 comments
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@flash1293
Copy link
Contributor

Once #80548 is merged, the central data structure in expression based applications in Kibana will contain a lot of meta information: https://github.com/elastic/kibana/pull/80548/files#diff-41350c285cb5101adad8c0903724e53baf6647112c540f76e065c79baf12a72aR70

Currently these pieces of information are generated by some datasources and consumed by some renderers, but there is no way to manipulate them. Also, existing expression functions might not treat them right.

TODOs:

  • Provide function to copy column meta data
  • Provide function to modify/remove column meta (meta todos: figure out how exactly this function would look like)
  • Vet existing functions whether they handle meta data gracefully
@flash1293 flash1293 added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 20, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
@ppisljar
Copy link
Member

@flash1293 does #78745 cover all the things you meant with this issue ? if so can we close it as a duplicate ?

@flash1293
Copy link
Contributor Author

@ppisljar It seems like #78745 is about providing utility Javascript functions while this issue is specifically about expression functions so meta data can be manipulated as part of the expression without writing use-case specific one-off expression functions.

@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Nov 22, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Feb 7, 2022
@ppisljar
Copy link
Member

ppisljar commented Mar 8, 2022

for now we don't plan to provide utility expression functions to manipulate meta with the reasoning that it should not be done from expressions. Specific functions might write meta information or manipulate it but this should not be controlled by the writer of expression

@ppisljar ppisljar closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

No branches or pull requests

4 participants