Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Storybook Controls instead of Knobs #80705

Merged
merged 5 commits into from
Oct 21, 2020
Merged

Use Storybook Controls instead of Knobs #80705

merged 5 commits into from
Oct 21, 2020

Commits on Oct 14, 2020

  1. Change syncbadge to controls

    @smith
    smith committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    143c6a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Merge remote-tracking branch 'upstream/master' into nls/sb-controls

    @smith
    smith committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    caf92b3 View commit details
    Browse the repository at this point in the history

  2. Use Storybook Controls instead of Knobs 

    * Change an example in embeddable to use controls instead of knobs
* Add controls to SyncBadge APM story
* Convert both to [CSF](https://storybook.js.org/docs/react/api/csf)
* Remove the Knobs addon from the default Storybook configuration

Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
    @smith
    smith committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    bda6611 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Merge remote-tracking branch 'upstream/master' into nls/sb-controls

    @smith
    smith committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    cfd5398 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Merge branch 'master' into nls/sb-controls

    @kibanamachine
    kibanamachine authored Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a7d70ea View commit details
    Browse the repository at this point in the history