Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update index management docs #80893

Merged
merged 17 commits into from
Oct 20, 2020
Merged

[DOCS] Update index management docs #80893

merged 17 commits into from
Oct 20, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 16, 2020

Summary

Updates the documentation and several screenshots for the ES UI Index Management section.

Preview

https://kibana_80893.docs-preview.app.elstc.co/guide/en/kibana/master/managing-indices.html

Checklist

  • Documentation was added for features that require explanation or tutorials

@jrodewig jrodewig added docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs Feature:elasticsearch labels Oct 16, 2020
@jrodewig jrodewig marked this pull request as ready for review October 16, 2020 19:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
@jrodewig
Copy link
Contributor Author

Thanks for the feedback @gchaps. 🙇 I've made several updates based on your suggestions.

I also reviewed the PRs you linked and updated my language so it's consistent. It's possible that there will still be merge conflicts, but this should make those easier if they occur.

This is ready for another look at your convenience!

@jrodewig jrodewig requested a review from gchaps October 16, 2020 22:12
@jrodewig jrodewig changed the title [DOCS] Update screenshots in index management docs [DOCS] Update index management docs Oct 16, 2020
docs/management/managing-indices.asciidoc Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
@jrodewig
Copy link
Contributor Author

Thanks for the additional feedback @gchaps. This is ready for another review at your convenience.

@jrodewig jrodewig requested a review from gchaps October 19, 2020 20:47
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but otherwise LGTM

docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-indices.asciidoc Show resolved Hide resolved
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻 Looks awesome! Thank you for doing this @jrodewig !

@jrodewig jrodewig merged commit 383fa56 into elastic:master Oct 20, 2020
@jrodewig jrodewig deleted the docs__update-index-mgmt-screenshots branch October 20, 2020 12:38
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants