Kibana usage collection to ts project refs #81265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
chore
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
TinaHeiligers
commented
Oct 21, 2020
| "../src/plugins/usage_collection/**/*", | ||
| "../src/plugins/telemetry_collection_manager/**/*", | ||
| "../src/plugins/telemetry/**/*" | ||
| "plugins/global_search/**/*" |
There was a problem hiding this comment.
self-review: I deleted the usage_collection, telemetry_collection_manager and telemetry plugin paths from "exclude" because they're not referenced in the "include" array. "exclude" only applies to directories listed in the "include" array and there isn't a path to "../src/plugins".
Bamieh
approved these changes
Oct 21, 2020
…collection-to-ts-project-refs
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
7 tasks
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
TinaHeiligers
added a commit
that referenced
this pull request
Oct 21, 2020
lukeelmers
added
Feature:Telemetry
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts
kibana_usage_collectionplugin to a separate ts project.Part of #81017
Condensed output from node --max-old-space-size=4096 ./node_modules/.bin/tsc -p tsconfig.json --extendedDiagnostics --noEmit given in the after section for each plugin.
Before:
Files: 5289
Lines: 707035
After:
Files: 5255
Lines: 704116