Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO management: fix legacy import index pattern selection being reset when switching page #81621

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Oct 26, 2020

Summary

Fix #75797

Checklist

Release Note

Fix a bug causing the index pattern override selection to be cleared when switching page while performing a legacy format saved object import.

@pgayvallet pgayvallet added release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 labels Oct 26, 2020
@pgayvallet pgayvallet marked this pull request as ready for review October 27, 2020 11:11
@pgayvallet pgayvallet requested a review from a team as a code owner October 27, 2020 11:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor Author

Note: this can't be backported below 7.11 as elastic/eui#3982 is only effective on lower Kibana versions.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
savedObjectsManagement 175.5KB 176.2KB +772.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 21615c1 into elastic:master Oct 30, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Oct 30, 2020
…when switching page (elastic#81621)

* fix legacy import index pattern selection being reset when switching pages

* update snapshots
pgayvallet added a commit that referenced this pull request Oct 30, 2020
…when switching page (#81621) (#82118)

* fix legacy import index pattern selection being reset when switching pages

* update snapshots
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 30, 2020
* master: (71 commits)
  [Chrome] Extension to append an element to the last breadcrumb (elastic#82015)
  [Monitoring] Thread pool rejections alert (elastic#79433)
  [Actions] Fix actionType type on registerType function (elastic#82125)
  [Security Solution] Modal for saving timeline (elastic#81802)
  add tests for index pattern switching (elastic#81987)
  TS project references for share plugin (elastic#82051)
  [Graph] Fix problem with duplicate ids (elastic#82109)
  skip 'returns a single bucket if array has 1'.  related elastic#81460
  Add a link to documentation in the alerts and actions management UI (elastic#81909)
  [Fleet] fix duplicate ingest pipeline refs (elastic#82078)
  Context menu trigger for URL Drilldown (elastic#81158)
  SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621)
  Fixed dead links (elastic#78696)
  [Search] Add "restore" to session service (elastic#81924)
  fix Lens heading structure (elastic#81752)
  [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011)
  Remove legacy app arch items from codeowners. (elastic#82084)
  [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939)
  Expressions/migrations2 (elastic#81281)
  [Telemetry] [Schema] remove number type and support all es number types (elastic#81774)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy Saved Object Import UI - Choices on the index patterns override page are reset
4 participants