[Actions] Microsoft Teams connector #83169

ymao1 · 2020-11-11T14:34:06Z

Resolves #56395

Summary

Added Microsoft Teams connector that uses the Incoming Webhook app available on Teams to post messages to channels within a team. There are fancier formatting options available but this PR does not take advantage of them.

Teams Connector on Create Connector Flyout

Creating a Teams Connector

Editing a Teams Connector

Testing a Teams Connector

Messages showing up on Teams

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…ns/microsoft-teams

elasticmachine · 2020-11-11T17:49:33Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1 · 2020-11-11T17:50:18Z

@gchaps could you review the words in the asciidocs please? Thanks!

mikecote

Changes LGTM! Great to see this integration! I left a few nits and questions.

...ugins/triggers_actions_ui/public/application/components/builtin_action_types/teams/teams.tsx

mikecote · 2020-11-12T14:42:12Z

x-pack/plugins/actions/server/builtin_action_types/teams.ts

+}): TeamsActionType {
+  return {
+    id: '.teams',
+    minimumLicenseRequired: 'gold',


@arisonl just to confirm, Teams is gold license?

...ugins/triggers_actions_ui/public/application/components/builtin_action_types/teams/teams.tsx

gchaps

UI copy looks good.

Can the messages that show up on Microsoft teams be a little friendlier? Instead of "something happened" but give some details of what went wrong?

ymao1 · 2020-11-12T15:59:34Z

Can the messages that show up on Microsoft teams be a little friendlier? Instead of "something happened" but give some details of what went wrong?

@gchaps Those are just my test messages :) The user can specify what the notification message is and there are default messages for each alert type

…ns/microsoft-teams

gchaps

LGTM

YulNaumenko

LGTM!

pmuellr

With two reviews already, didn't do a full one, but did look through the server-side code. LGTM!

Noted some potentially extraneous logging - I suspect we have other actions are also logging errors when they don't need to (no need to fix here) and so this was probably copied from one of those, but if those logs ARE extraneous, might as well change them to debugs for when someone copies THIS action when creating a new one :-)

x-pack/plugins/actions/server/builtin_action_types/teams.ts

…ns/microsoft-teams

ymao1 · 2020-11-16T03:24:40Z

@elasticmachine merge upstream

…ns/microsoft-teams

ymao1 · 2020-11-20T14:31:34Z

@elasticmachine merge upstream

kibanamachine · 2020-11-20T16:11:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 84339e9

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	277	282	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.5MB	+21.3KB

Distributable file count

id	before	after	diff
`default`	42957	42966	+9

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	152.2KB	154.7KB	+2.5KB

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	31	33	+2

miscellaneous assets size

id	before	after	diff
`triggersActionsUi`	27.7KB	37.7KB	+10.0KB

History

💚 Build #87967 succeeded 18206aa
💔 Build #87893 failed 9274703
💚 Build #87728 succeeded 4bcec56
💚 Build #87690 succeeded 2f240d0
💔 Build #87672 failed 4f81aa3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* First cut at adding teams connector * Getting teams connector working * Unit tests * Updating docs * PR comments * PR comments * Changing error to debug log * Fixing imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* First cut at adding teams connector * Getting teams connector working * Unit tests * Updating docs * PR comments * PR comments * Changing error to debug log * Fixing imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…Actions (#94239) ## Summary This PR enables Microsoft Teams action type for the detection engine (originally developed/tested via #83169). <img width="500" src="https://user-images.githubusercontent.com/2946766/110558632-0fccdf80-8100-11eb-8476-8adb2eab7134.png" /> ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

…Actions (elastic#94239) ## Summary This PR enables Microsoft Teams action type for the detection engine (originally developed/tested via elastic#83169). <img width="500" src="https://user-images.githubusercontent.com/2946766/110558632-0fccdf80-8100-11eb-8476-8adb2eab7134.png" /> ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

…Actions (#94239) (#94260) ## Summary This PR enables Microsoft Teams action type for the detection engine (originally developed/tested via #83169). <img width="500" src="https://user-images.githubusercontent.com/2946766/110558632-0fccdf80-8100-11eb-8476-8adb2eab7134.png" /> ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

…Actions (#94239) (#94261) ## Summary This PR enables Microsoft Teams action type for the detection engine (originally developed/tested via #83169). <img width="500" src="https://user-images.githubusercontent.com/2946766/110558632-0fccdf80-8100-11eb-8476-8adb2eab7134.png" /> ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

ymao1 added 6 commits November 6, 2020 13:36

First cut at adding teams connector

fc513ad

Merge branch 'master' of https://github.com/elastic/kibana into actio…

ec4a31e

…ns/microsoft-teams

Getting teams connector working

acddc38

Merge branch 'master' of https://github.com/elastic/kibana into actio…

547509e

…ns/microsoft-teams

Unit tests

bb9bb02

Updating docs

3d2aaa5

ymao1 self-assigned this Nov 11, 2020

ymao1 added Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0 labels Nov 11, 2020

ymao1 marked this pull request as ready for review November 11, 2020 17:49

ymao1 requested a review from gchaps November 11, 2020 17:49

mikecote requested review from mikecote and a team November 12, 2020 14:00

mikecote approved these changes Nov 12, 2020

View reviewed changes

gchaps reviewed Nov 12, 2020

View reviewed changes

ymao1 added 3 commits November 12, 2020 11:51

Merge branch 'master' of https://github.com/elastic/kibana into actio…

356cc58

…ns/microsoft-teams

PR comments

4f81aa3

PR comments

2f240d0

gchaps approved these changes Nov 12, 2020

View reviewed changes

YulNaumenko approved these changes Nov 12, 2020

View reviewed changes

pmuellr approved these changes Nov 12, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/teams.ts Outdated Show resolved Hide resolved

ymao1 added 2 commits November 12, 2020 15:10

Merge branch 'master' of https://github.com/elastic/kibana into actio…

8e77582

…ns/microsoft-teams

Changing error to debug log

4bcec56

kibanamachine and others added 3 commits November 15, 2020 22:24

Merge branch 'master' into actions/microsoft-teams

9274703

Merge branch 'master' of https://github.com/elastic/kibana into actio…

e4ad9f3

…ns/microsoft-teams

Fixing imports

18206aa

Merge branch 'master' into actions/microsoft-teams

84339e9

ymao1 merged commit 8ca1e93 into elastic:master Nov 20, 2020

ymao1 mentioned this pull request Nov 20, 2020

[7.x] [Actions] Microsoft Teams connector (#83169) #83930

Merged

mikecote added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 16, 2020

ymao1 deleted the actions/microsoft-teams branch February 4, 2021 15:25

spong mentioned this pull request Mar 10, 2021

[SecuritySolution][Detections] Enables Microsoft Teams for Detection Actions #94239

Merged

1 task

geekpete mentioned this pull request Sep 28, 2021

[DOCS] document missing enabledActionTypes value for Microsoft Teams action #113211

Merged

pmuellr mentioned this pull request Jan 25, 2022

[ResponseOps] MS Teams connector does not have any functional tests #123715

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Actions] Microsoft Teams connector #83169

[Actions] Microsoft Teams connector #83169

ymao1 commented Nov 11, 2020 •

edited

Loading

elasticmachine commented Nov 11, 2020

ymao1 commented Nov 11, 2020

mikecote left a comment

mikecote Nov 12, 2020

gchaps left a comment

ymao1 commented Nov 12, 2020

gchaps left a comment

YulNaumenko left a comment

pmuellr left a comment

ymao1 commented Nov 16, 2020

ymao1 commented Nov 20, 2020

kibanamachine commented Nov 20, 2020

async chunk count

miscellaneous assets size

[Actions] Microsoft Teams connector #83169

[Actions] Microsoft Teams connector #83169

Conversation

ymao1 commented Nov 11, 2020 • edited Loading

Summary

Teams Connector on Create Connector Flyout

Creating a Teams Connector

Editing a Teams Connector

Testing a Teams Connector

Messages showing up on Teams

Checklist

elasticmachine commented Nov 11, 2020

ymao1 commented Nov 11, 2020

mikecote left a comment

Choose a reason for hiding this comment

mikecote Nov 12, 2020

Choose a reason for hiding this comment

gchaps left a comment

Choose a reason for hiding this comment

ymao1 commented Nov 12, 2020

gchaps left a comment

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

ymao1 commented Nov 16, 2020

ymao1 commented Nov 20, 2020

kibanamachine commented Nov 20, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

Page load bundle

async chunk count

miscellaneous assets size

History

ymao1 commented Nov 11, 2020 •

edited

Loading