Derive the port from the protocol in cases where it's not explicitly in the URL #83583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgriffith
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
streamich
approved these changes
Nov 18, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 18, 2020
…o-node-details * 'master' of github.com:elastic/kibana: Derive the port from the protocol in cases where it's not explicitly stated (elastic#83583) [CI] Build docker image during packer_cache (elastic#82145) [esaggs][inspector]: Refactor to prep for esaggs move to server. (elastic#83199)
joelgriffith
pushed a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kibana can make requests to URLs like: https://feeds-staging.elastic.co/kibana/v8.0.0.json, which doesn't explicitly list its own port. This PR enhances our port/hostname/protocol check to "derive" the port from the protocol in cases where it's not explicitly listed.