Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use of console-stamp #83922

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Drop use of console-stamp #83922

merged 1 commit into from
Nov 22, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Nov 20, 2020

No description provided.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.10.1 labels Nov 20, 2020
@watson watson requested a review from a team as a code owner November 20, 2020 14:55
@watson watson self-assigned this Nov 20, 2020
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

dgieselaar
dgieselaar approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas!

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/event_log·ts.alerting api integration spaces only Alerting eventLog should generate expected events for normal operation

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/81668

[00:00:00]       │
[00:00:00]         │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1605884150862398894] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.apm-agent-configuration][0]]])." previous.health="YELLOW" reason="shards started [[.apm-agent-configuration][0]]"
[00:00:00]         │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1605884150862398894] [.kibana_task_manager_1/tGk7YT5nQ_OTDB1pZ2Z6Gw] update_mapping [_doc]
[00:00:00]         └-: alerting api integration spaces only
[00:00:00]           └-> "before all" hook
[00:00:45]           └-: Alerting
[00:00:45]             └-> "before all" hook
[00:00:45]             └-> "before all" hook
[00:00:45]               │ debg creating space
[00:00:45]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1605884150862398894] [.kibana_2/BiAmnN4-T8GLpFRMC_uSSA] update_mapping [_doc]
[00:00:46]               │ debg created space
[00:00:46]               │ debg creating space
[00:00:47]               │ debg created space
[00:02:34]             └-: eventLog
[00:02:34]               └-> "before all" hook
[00:02:34]               └-> should generate expected events for normal operation
[00:02:34]                 └-> "before each" hook: global before each
[00:02:36]                 │ debg --- retry.try error: no events found yet
[00:02:36]                 │ debg --- retry.try failed again with the same message...
[00:02:37]                 │ debg --- retry.try failed again with the same message...
[00:02:37]                 │ proc [kibana]   log   [16:03:30.078] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:30.061Z","event":{"provider":"alerting","action":"execute","start":"2020-11-20T16:03:30.061Z","outcome":"success","end":"2020-11-20T16:03:30.074Z","duration":13000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc'","ecs":{"version":"1.6.0"}}
[00:02:37]                 │ debg --- retry.try failed again with the same message...
[00:02:38]                 │ debg --- retry.try failed again with the same message...
[00:02:38]                 │ debg --- retry.try error: no event found with action "execute-action"
[00:02:39]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ proc [kibana]   log   [16:03:33.079] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:33.072Z","event":{"provider":"alerting","action":"new-instance"},"kibana":{"alerting":{"instance_id":"instance","action_group_id":"default"},"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc' created new instance: 'instance'","ecs":{"version":"1.6.0"}}
[00:02:40]                 │ proc [kibana]   log   [16:03:33.081] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:33.073Z","event":{"provider":"alerting","action":"active-instance"},"kibana":{"alerting":{"instance_id":"instance","action_group_id":"default"},"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc' active instance: 'instance' in actionGroup: 'default'","ecs":{"version":"1.6.0"}}
[00:02:41]                 │ debg --- retry.try failed again with the same message...
[00:02:41]                 │ proc [kibana]   log   [16:03:33.677] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:33.675Z","event":{"provider":"alerting","action":"execute-action"},"kibana":{"alerting":{"instance_id":"instance","action_group_id":"default"},"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"},{"type":"action","id":"2941d683-5980-4995-bb87-31387a6a60e4","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert: test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc' instanceId: 'instance' scheduled actionGroup: 'default' action: test.noop:2941d683-5980-4995-bb87-31387a6a60e4","ecs":{"version":"1.6.0"}}
[00:02:41]                 │ proc [kibana]   log   [16:03:33.681] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:33.056Z","event":{"provider":"alerting","action":"execute","start":"2020-11-20T16:03:33.056Z","outcome":"success","end":"2020-11-20T16:03:33.679Z","duration":623000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"alerting":{"status":"active"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc'","ecs":{"version":"1.6.0"}}
[00:02:41]                 │ debg --- retry.try failed again with the same message...
[00:02:42]                 │ debg --- retry.try error: no event found with action "resolved-instance"
[00:02:42]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ proc [kibana]   log   [16:03:36.088] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:36.083Z","event":{"provider":"alerting","action":"active-instance"},"kibana":{"alerting":{"instance_id":"instance","action_group_id":"default"},"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc' active instance: 'instance' in actionGroup: 'default'","ecs":{"version":"1.6.0"}}
[00:02:43]                 │ proc [kibana]   log   [16:03:36.109] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:36.104Z","event":{"provider":"actions","action":"execute","start":"2020-11-20T16:03:36.103Z","end":"2020-11-20T16:03:36.103Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"action","id":"2941d683-5980-4995-bb87-31387a6a60e4","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"action executed: test.noop:2941d683-5980-4995-bb87-31387a6a60e4: MY action","ecs":{"version":"1.6.0"}}
[00:02:44]                 │ debg --- retry.try failed again with the same message...
[00:02:44]                 │ proc [kibana]   log   [16:03:36.705] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:36.703Z","event":{"provider":"alerting","action":"execute-action"},"kibana":{"alerting":{"instance_id":"instance","action_group_id":"default"},"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"},{"type":"action","id":"2941d683-5980-4995-bb87-31387a6a60e4","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert: test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc' instanceId: 'instance' scheduled actionGroup: 'default' action: test.noop:2941d683-5980-4995-bb87-31387a6a60e4","ecs":{"version":"1.6.0"}}
[00:02:44]                 │ proc [kibana]   log   [16:03:36.708] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:36.061Z","event":{"provider":"alerting","action":"execute","start":"2020-11-20T16:03:36.061Z","outcome":"success","end":"2020-11-20T16:03:36.706Z","duration":645000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"alerting":{"status":"active"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc'","ecs":{"version":"1.6.0"}}
[00:02:44]                 │ debg --- retry.try failed again with the same message...
[00:02:45]                 │ debg --- retry.try failed again with the same message...
[00:02:45]                 │ debg --- retry.try failed again with the same message...
[00:02:46]                 │ debg --- retry.try failed again with the same message...
[00:02:46]                 │ proc [kibana]   log   [16:03:39.078] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:39.075Z","event":{"provider":"alerting","action":"resolved-instance"},"kibana":{"alerting":{"instance_id":"instance","action_group_id":"default"},"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc' resolved instance: 'instance'","ecs":{"version":"1.6.0"}}
[00:02:46]                 │ proc [kibana]   log   [16:03:39.083] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:39.063Z","event":{"provider":"alerting","action":"execute","start":"2020-11-20T16:03:39.063Z","outcome":"success","end":"2020-11-20T16:03:39.080Z","duration":17000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"c034381a-bfc1-4522-b090-9c5b79611142","namespace":"space1"}],"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.patternFiring:c034381a-bfc1-4522-b090-9c5b79611142: 'abc'","ecs":{"version":"1.6.0"}}
[00:02:46]                 │ proc [kibana]   log   [16:03:39.098] [info][eventLog][plugins] event logged: {"@timestamp":"2020-11-20T16:03:39.094Z","event":{"provider":"actions","action":"execute","start":"2020-11-20T16:03:39.094Z","end":"2020-11-20T16:03:39.094Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"action","id":"2941d683-5980-4995-bb87-31387a6a60e4","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"action executed: test.noop:2941d683-5980-4995-bb87-31387a6a60e4: MY action","ecs":{"version":"1.6.0"}}
[00:02:46]                 └- ✖ fail: alerting api integration spaces only Alerting eventLog should generate expected events for normal operation
[00:02:46]                 │      Error: expected false to equal true
[00:02:46]                 │       at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:100:11)
[00:02:46]                 │       at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:227:8)
[00:02:46]                 │       at Assertion.be (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:69:22)
[00:02:46]                 │       at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/alerting/event_log.ts:91:44)
[00:02:46]                 │       at Object.apply (/dev/shm/workspace/parallel/18/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:02:46]                 │ 
[00:02:46]                 │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/alerting/event_log.ts:91:44)
    at Object.apply (/dev/shm/workspace/parallel/18/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 731.8KB 731.7KB -58.0B

Distributable file count

id before after diff
default 42957 42956 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.5KB 60.4KB -58.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit 90658d5 into elastic:master Nov 22, 2020
@watson watson deleted the drop-console-stamp branch November 22, 2020 10:15
@watson watson mentioned this pull request Nov 22, 2020
Merged
watson added a commit that referenced this pull request Nov 23, 2020
@watson
Drop use of console-stamp (#83922) (#84016)
cacd199
gmmorris added a commit to rudolf/kibana that referenced this pull request Nov 23, 2020
@gmmorris
Merge branch 'master' into pr/83866
0745518 
* master: (67 commits)
  [Observability] Load hasData call asynchronously (elastic#80644)
  Implement AnonymousAuthenticationProvider. (elastic#79985)
  Deprecate `visualization:colorMapping` advanced setting (elastic#83372)
  [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635)
  Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037)
  skip flaky suite (elastic#83772)
  skip flaky suite (elastic#69849)
  create kbn-legacy-logging package (elastic#77678)
  [Search] Search batching using bfetch (elastic#83418)
  [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033)
  Drop use of console-stamp (elastic#83922)
  skip flaky suite (elastic#84011 , elastic#84012)
  Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760)
  [maps] support URL drilldowns (elastic#83732)
  Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)"
  [code coverage] Update jest config to collect more data (elastic#83804)
  Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)
  [Security Solution] Give notice when endpoint policy is out of date (elastic#83469)
  [Security Solution] Sync url state on any changes to query string (elastic#83314)
  [CI] Initial TeamCity implementation (elastic#81043)
  ...
@watson watson removed the v7.10.1 label Nov 23, 2020
watson added a commit to watson/kibana that referenced this pull request Nov 23, 2020
@watson
Revert "Drop use of console-stamp (elastic#83922)"
4961f53 
This reverts commit 90658d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees

@watson watson

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@watson @elasticmachine @kibanamachine @dgieselaar