[ML] Fix swim lane for top influencers #84258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Nov 24, 2020
| * For the "View by" swim lane the limit is the cardinality of the influencer values, | ||
| * which is known after the initial fetch. | ||
| * When looking up for top influencers for selected range in Overall swim lane | ||
| * the result is filtered by top influencers values, hence there is no need ot set the limit. |
There was a problem hiding this comment.
Nit - typo ot should be to
alvarezmelissa87
approved these changes
Nov 24, 2020
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This was referenced Nov 24, 2020
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Nov 24, 2020
* [ML] fix swim lane with page size for top influencers, fix swim lane sorting * [ML] fix typo
darnautov
added a commit
that referenced
this pull request
Nov 25, 2020
darnautov
added a commit
that referenced
this pull request
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When cells on the "Overall" swim lane are selected, we filter the "View By" swim lane based on the top influencers in that range. This PR fixes the request for this case by removing the limit (based on cardinality).
Fix swim lane sorting when top influencers are presented:
Before:
After:
