-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Show color in flyout instead of auto #84532
Merged
flash1293
merged 3 commits into
elastic:master
from
flash1293:lens/show-color-instead-of-auto
Dec 2, 2020
Merged
[Lens] Show color in flyout instead of auto #84532
flash1293
merged 3 commits into
elastic:master
from
flash1293:lens/show-color-instead-of-auto
Dec 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in FF and wasn't able to break the color assignment any of the ways I tried. Code also looks good, once I figured out that a big chunk of the code was a copy + paste from existing color assignment code.
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Dec 2, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 2, 2020
* master: [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) endpoint telemetry cloned endpoint tests (elastic#81498) [Fleet] Handler api key creation errors when Fleet Admin is invalid (elastic#84576)
flash1293
added a commit
that referenced
this pull request
Dec 2, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 2, 2020
* master: (72 commits) Make alert status fetching more resilient (elastic#84676) [APM] Refactor hooks and context (elastic#84615) Added word break styles to the texts in the item details card. (elastic#84654) [Search] Disable "send to background" when auto-refresh is enabled (elastic#84106) Add readme for new palette service (elastic#84512) Make all providers to preserve original URL when session expires. (elastic#84229) [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already show the current color (no matter whether auto or not) in the dimension trigger. But in the flyout itself it just says "auto":
![Screenshot 2020-11-30 at 16 37 01](https://user-images.githubusercontent.com/1508364/100630065-5acd9e80-332a-11eb-99cd-6f90854a3421.png)
This PR reuses the same information and pre-sets the color picker correctly:
![Screenshot 2020-11-30 at 16 37 11](https://user-images.githubusercontent.com/1508364/100630152-7c2e8a80-332a-11eb-987c-a127e6c70d83.png)
If a custom color is set, the "reset" button is shown in the input - clicking it brings back the old auto color:
![Screenshot 2020-11-30 at 16 37 17](https://user-images.githubusercontent.com/1508364/100630198-88b2e300-332a-11eb-83fb-bb7c0cab2b4d.png)
The code for showing "auto" is still left in because in some rare edge cases it's possible the current auto color can't be determined (if the chart is still loading)