Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 #84768

Merged
merged 5 commits into from Dec 15, 2020
Merged

Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 #84768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5407e9
Gauge visualization can no longer be clicked to filter on values sinc…
DianaDerevyankina Dec 2, 2020
cdf505f
Merge branch 'master' into Diana/84191
DianaDerevyankina Dec 7, 2020
2e0a2d4
Merge branch 'master' into Diana/84191
DianaDerevyankina Dec 10, 2020
2b7756b
Merge branch 'master' into Diana/84191
DianaDerevyankina Dec 14, 2020
efbf268
Add functional test to filtering on gauge
DianaDerevyankina Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plugins/vis_type_vislib/public/gauge.ts
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ import { GaugeOptions } from './components/options';
import { getGaugeCollections, Alignments, GaugeTypes } from './utils/collections';
import { ColorModes, ColorSchemas, ColorSchemaParams, Labels, Style } from '../../charts/public';
import { toExpressionAst } from './to_ast';
import { BaseVisTypeOptions } from '../../visualizations/public';
import { BaseVisTypeOptions, VIS_EVENT_TO_TRIGGER } from '../../visualizations/public';
import { BasicVislibParams } from './types';

export interface Gauge extends ColorSchemaParams {
Expand Down Expand Up @@ -63,6 +63,7 @@ export const gaugeVisTypeDefinition: BaseVisTypeOptions<BasicVislibParams> = {
description: i18n.translate('visTypeVislib.gauge.gaugeDescription', {
defaultMessage: 'Show the status of a metric.',
}),
getSupportedTriggers: () => [VIS_EVENT_TO_TRIGGER.filter],
toExpressionAst,
visConfig: {
defaults: {
Expand Down
5 changes: 4 additions & 1 deletion src/plugins/vis_type_vislib/public/vislib/visualizations/gauge_chart.js
View file
Open in desktop
Expand Up @@ -31,7 +31,10 @@ export class GaugeChart extends Chart {
addEvents(element) {
const events = this.events;

return element.call(events.addHoverEvent()).call(events.addMouseoutEvent());
return element
.call(events.addHoverEvent())
.call(events.addMouseoutEvent())
.call(events.addClickEvent());
}

/**
Expand Down