[ILM] Reposition form toggles #85143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mRow and added new ToggleFieldWithDescribedFormRow component
jloleysens
added
release_note:enhancement
Feature:ILM
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Code LGTM. Nice work!
I'm not sure if there's an open issue around this yet or not, but if I enable Set replicas and set a value, then go back to edit it and disable the toggle and save, it doesn't reset this field; it remains whatever value I set it the first time. I checked out master and I was able to reproduce there as well. Let me know if you'd like me to open up an issue for this!
|
Thanks for the review @alisonelizabeth ! I was able to reproduce the the bug and will create a PR to fix it shortly! This will not have been released but I will create an issue for tracking! |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 8, 2020
* merged toggleable field and described form component and moved toggle to left * moved all toggles to left, renamed DescribedFormField -> DescribedFormRow and added new ToggleFieldWithDescribedFormRow component * added new prop fieldNotices to render callouts in correct position on the left
|
@alisonelizabeth issue for tracking: #85226 |
1 task
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 8, 2020
…or-disable-searchable-snapshot-fields * 'master' of github.com:elastic/kibana: (29 commits) HTTP CRUD+ API for Index Patterns (elastic#83576) Don't list packages in devDependencies already listed in dependencies (elastic#85120) Remove unused devDependencies (elastic#85121) [ILM] Reposition form toggles (elastic#85143) [APM] Make sure jest script can be run from anywhere (elastic#85111) Add EuiButtonEmptyTo components (elastic#85213) skip flaky suite (elastic#85216) skip flaky suite (elastic#83775) skip flaky suite (elastic#83774) skip flaky suite (elastic#83773) skip flaky suite (elastic#83793) skip flaky suite (elastic#85215) skip flaky suite (elastic#85217) [Usage Collection] Kibana Overview Page UI Metrics (elastic#81937) [Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API (elastic#84604) skip flaky suite (elastic#85208) [Security Solutions][Detection Engine] Fixes cypress errors by using latest signals mapping (elastic#84600) Small fixes to Kibana search bar (elastic#85079) Change link text to say Fleet (elastic#85083) [Metrics UI] Refactor Process List API to fetch only top processes (elastic#84716) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
jloleysens
added a commit
that referenced
this pull request
Dec 8, 2020
* merged toggleable field and described form component and moved toggle to left * moved all toggles to left, renamed DescribedFormField -> DescribedFormRow and added new ToggleFieldWithDescribedFormRow component * added new prop fieldNotices to render callouts in correct position on the left
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move all ILM field toggles to the left side per ES UI form field guidelines.
CC @mdefazio
Screenshots
Before
After
Warm phase fields
Field with notifications
Release note
We brought form fields in ILM more in line with ESUI standards.