Deprecate disabling the security plugin #85159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
release_note:deprecation
Team:Security
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…ecate-disabling-plugin
…ego/kibana into security/deprecate-disabling-plugin
legrego
commented
Dec 8, 2020
|
|
||
| import { ConfigDeprecationProvider } from 'src/core/server'; | ||
|
|
||
| export const securityConfigDeprecationProvider: ConfigDeprecationProvider = ({ |
There was a problem hiding this comment.
note with the exception of the last deprecation in this array, this was simply lifted from index.ts in order to facilitate unit testing
|
Pinging @elastic/kibana-security (Team:Security) |
|
ACK: will review today |
azasypkin
approved these changes
Dec 9, 2020
| @@ -40,53 +41,7 @@ export { AuthenticatedUser } from '../common/model'; | |||
|
|
|||
| export const config: PluginConfigDescriptor<TypeOf<typeof ConfigSchema>> = { | |||
| schema: ConfigSchema, | |||
| deprecations: ({ rename, unused }) => [ | |||
There was a problem hiding this comment.
Thanks for moving this to a separate file and adding tests! ❤️
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Dec 9, 2020
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security/server/index.ts
legrego
added a commit
that referenced
this pull request
Dec 10, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 10, 2020
* master: (53 commits) Fixing recovered instance reference bug (elastic#85412) Switch to new elasticsearch client for Visualizations (elastic#85245) Switch to new elasticsearch client for TSVB (elastic#85275) Switch to new elasticsearch client for Vega (elastic#85280) [ILM] Add shrink field to hot phase (elastic#84087) Add rolling-file appender to core logging (elastic#84735) [APM] Service overview: Dependencies table (elastic#83416) [Uptime ]Update empty message for certs list (elastic#78575) [Graph] Fix graph saved object references (elastic#85295) [APM] Create new API's to return Latency and Throughput charts (elastic#85242) [Advanced settings] Reset to default for empty strings (elastic#85137) [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (elastic#83761) [Fleet] Update agent listing for better status reporting (elastic#84798) [APM] enable 'sanitize_field_names' for Go (elastic#85373) Update dependency @elastic/charts to v24.4.0 (elastic#85452) Introduce external url service (elastic#81234) Deprecate disabling the security plugin (elastic#85159) [FLEET] New Integration Policy Details page for use in Integrations section (elastic#85355) [Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API chore: 🤖 remove extraPublicDirs (elastic#85454) ...
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the ability to disable the security plugin via
xpack.security.enabled: false. This is a first step towards #66621 (comment)Our intent is to prevent the security plugin from being disabled in 8.0. Users who don't wish to use security should instead disable security features within Elasticsearch.