Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 馃 remove extraPublicDirs #85454

Merged
merged 1 commit into from
Dec 9, 2020
Merged

chore: 馃 remove extraPublicDirs #85454

merged 1 commit into from
Dec 9, 2020

Conversation

streamich
Copy link
Contributor

Summary

Removes "extraPublicDirs" in UI Actions to reduce the size of browser bundle.

@streamich streamich requested a review from a team as a code owner December 9, 2020 17:55
@kibanamachine
Copy link
Contributor

馃挌 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uiActions 31 29 -2

Distributable file count

id before after diff
default 46981 47741 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActions 67.8KB 65.3KB -2.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich added Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review Team:AppServices v7.11.0 v8.0.0 labels Dec 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@streamich streamich merged commit ac06cb8 into elastic:master Dec 9, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 10, 2020
@gmmorris
Merge branch 'master' into alerts/force-schedule
b4defa6 
* master: (53 commits)
  Fixing recovered instance reference bug (elastic#85412)
  Switch to new elasticsearch client for Visualizations (elastic#85245)
  Switch to new elasticsearch client for TSVB (elastic#85275)
  Switch to new elasticsearch client for Vega (elastic#85280)
  [ILM] Add shrink field to hot phase (elastic#84087)
  Add rolling-file appender to core logging (elastic#84735)
  [APM] Service overview: Dependencies table (elastic#83416)
  [Uptime ]Update empty message for certs list (elastic#78575)
  [Graph] Fix graph saved object references (elastic#85295)
  [APM] Create new API's to return Latency and Throughput charts (elastic#85242)
  [Advanced settings] Reset to default for empty strings (elastic#85137)
  [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (elastic#83761)
  [Fleet] Update agent listing for better status reporting (elastic#84798)
  [APM] enable 'sanitize_field_names' for Go (elastic#85373)
  Update dependency @elastic/charts to v24.4.0 (elastic#85452)
  Introduce external url service (elastic#81234)
  Deprecate disabling the security plugin (elastic#85159)
  [FLEET] New Integration Policy Details page for use in Integrations section (elastic#85355)
  [Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API
  chore: 馃 remove extraPublicDirs (elastic#85454)
  ...
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn鈥檛 been backported yet.
To create backports run node scripts/backport --pr 85454 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 11, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn鈥檛 been backported yet.
To create backports run node scripts/backport --pr 85454 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn鈥檛 been backported yet.
To create backports run node scripts/backport --pr 85454 or prevent reminders by adding the backport:skip label.

@streamich streamich added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@streamich @kibanamachine @elasticmachine @mattkime