[ILM] Added readonly field in hot phase #85419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
yuliacech
added
Feature:ILM
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Great work @yuliacech! Thanks for adding support for this action. Tested locally and everything worked as expected. I left a couple nits, but nothing blocking.
| title={ | ||
| <h3> | ||
| <FormattedMessage | ||
| id="xpack.indexLifecycleMgmt.editPolicy.readonly.text" |
There was a problem hiding this comment.
Per the i18n guidelines, I think the end of this id should be something like ...editPolicy.readonlyTitle
...t/public/application/sections/edit_policy/components/phases/shared_fields/readonly_field.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts
Outdated
Show resolved
Hide resolved
...management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
Outdated
Show resolved
Hide resolved
| @@ -60,9 +60,16 @@ export const createSerializer = (originalPolicy?: SerializedPolicy) => ( | |||
| if (_meta.hot.bestCompression && hotPhaseActions.forcemerge) { | |||
| hotPhaseActions.forcemerge.index_codec = 'best_compression'; | |||
| } | |||
|
|
|||
| if (_meta.hot.readonlyEnabled) { | |||
| hotPhaseActions.readonly = hotPhaseActions.readonly ?? {}; | |||
There was a problem hiding this comment.
Won't this always equal {}, or is it possible to pass options to the readonly action?
There was a problem hiding this comment.
Currently, the readonly action is always empty, but I thought we should not overwrite the existing object in case ES will add any new properties.
|
@elasticmachine merge upstream |
…ections/edit_policy/components/phases/shared_fields/readonly_field.tsx Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
…ections/edit_policy/form/schema.ts Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
…ections/edit_policy/components/phases/hot_phase/hot_phase.tsx Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
|
Thanks a lot for your review and suggestions, @alisonelizabeth ! :) |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
yuliacech
added a commit
to yuliacech/kibana
that referenced
this pull request
Dec 14, 2020
* [ILM] Added readonly field in hot phase * [ILM] Added readonly field in warm phase * Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/readonly_field.tsx Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> * Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> * Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> * Updated labels for the form Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
yuliacech
added a commit
that referenced
this pull request
Dec 14, 2020
* [ILM] Added readonly field in hot phase * [ILM] Added readonly field in warm phase * Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/readonly_field.tsx Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> * Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> * Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> * Updated labels for the form Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #82880.
This PR adds
readonlyaction to hot and warm phases. Default is disabled and in hot phase it's only allowed if rollover is enabled.Screenshot
Checklist
Release note
Index Lifecycle Management app now includes readonly action.