Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] removes unnecessary panel in categories tab #86769

Merged
merged 1 commit into from
Dec 23, 2020
Merged

[Logs UI] removes unnecessary panel in categories tab #86769

merged 1 commit into from
Dec 23, 2020

Conversation

katrin-freihofner
Copy link
Contributor

Summary

This is a purely visual change. It removes the panel around the date picker on the categories view.

Screenshot 2020-12-22 at 14 45 52

@katrin-freihofner katrin-freihofner requested a review from a team as a code owner December 22, 2020 13:46
@katrin-freihofner katrin-freihofner changed the title removes unnecessary panel in categories tab [Logs UI] removes unnecessary panel in categories tabL Dec 22, 2020
@weltenwort weltenwort self-requested a review December 22, 2020 14:45
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort added this to the Logs UI 7.12 milestone Dec 22, 2020
@katrin-freihofner katrin-freihofner added the release_note:skip Skip the PR/issue when compiling release notes label Dec 22, 2020
weltenwort
weltenwort approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI 👍 thanks for the hands-on help!

@katrin-freihofner katrin-freihofner changed the title [Logs UI] removes unnecessary panel in categories tabL [Logs UI] removes unnecessary panel in categories tab Dec 23, 2020
@katrin-freihofner katrin-freihofner changed the title [Logs UI] removes unnecessary panel in categories tab [Logs UI] removes unnecessary panel in categories tabL Dec 23, 2020
@katrin-freihofner katrin-freihofner merged commit 0d3daa5 into elastic:master Dec 23, 2020
@katrin-freihofner katrin-freihofner deleted the logs-ui-remove-panel branch December 23, 2020 08:38
@weltenwort weltenwort changed the title [Logs UI] removes unnecessary panel in categories tabL [Logs UI] removes unnecessary panel in categories tab Dec 23, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB -119.0B

Distributable file count

id before after diff
default 47144 47904 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 25, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

7 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 86769 or prevent reminders by adding the backport:skip label.

@katrin-freihofner katrin-freihofner mentioned this pull request Jan 5, 2021
Merged
katrin-freihofner added a commit that referenced this pull request Jan 5, 2021
@katrin-freihofner
[7.x] [Logs UI] removes unnecessary panel in categories tabL (#86769) (…
76d8b49 
…#87283)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.12
Development

Successfully merging this pull request may close these issues.
4 participants
@katrin-freihofner @elasticmachine @kibanamachine @weltenwort