Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Custom links can still be created with a read only user. #87089

Merged
merged 5 commits into from
Jan 4, 2021
Merged

[APM] Custom links can still be created with a read only user. #87089

merged 5 commits into from
Jan 4, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #87025

Before:
Screenshot 2020-12-30 at 15 51 54

After:
Screenshot 2020-12-30 at 15 52 30

@cauemarcondes cauemarcondes requested a review from a team as a code owner December 31, 2020 10:16
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Would be great to have this for all ui elements that require write access (eg. agent config)

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

Nice! Would be great to have this for all ui elements that require write access (eg. agent config)

@sqren done!

Screenshot 2021-01-04 at 10 17 26

@formgeist
Copy link
Contributor

Small suggestion; would it be another nice addition to show a tooltip when hovering the disabled button to explain why it's disabled? E.g. "Your user role doesn't have permissions to create custom links/agent configurations"

@dgieselaar
Copy link
Member

@cauemarcondes doesn't the custom link create route need an access:apm_write tag?

@cauemarcondes
Copy link
Contributor Author

Small suggestion; would it be another nice addition to show a tooltip when hovering the disabled button to explain why it's disabled? E.g. "Your user role doesn't have permissions to create custom links/agent configurations"

@formgeist

Screenshot 2021-01-04 at 11 28 06

Screenshot 2021-01-04 at 11 29 16

@formgeist
Copy link
Contributor

@cauemarcondes thanks!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +1.1KB

Distributable file count

id before after diff
default 47264 48024 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit cd06251 into elastic:master Jan 4, 2021
@cauemarcondes cauemarcondes deleted the apm-custom-link-read-access branch January 4, 2021 12:50
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jan 4, 2021
@cauemarcondes @kibanamachine
[APM] Custom links can still be created with a read only user. (elast…
d9b569c 
…ic#87089)

* disabling buttons when user does not permission

* fixing test

* disabling create/edit button when user does not have write permission

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cauemarcondes cauemarcondes mentioned this pull request Jan 4, 2021
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jan 4, 2021
@cauemarcondes @kibanamachine
[APM] Custom links can still be created with a read only user. (elast…
0c9d848 
…ic#87089)

* disabling buttons when user does not permission

* fixing test

* disabling create/edit button when user does not have write permission

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cauemarcondes cauemarcondes mentioned this pull request Jan 4, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 4, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/pocish-ti…
7f12f76 
…meline-component

* 'master' of github.com:elastic/kibana: (955 commits)
  remove SameSite:None workaround (elastic#86994)
  URL encoding for URL drilldown (elastic#86902)
  [Security Solution] Fix few styling issues (elastic#87045)
  [APM] Custom links can still be created with a read only user. (elastic#87089)
  prevent double update (elastic#86794)
  Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113)
  [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093)
  [APM] Add range query to service map trace walk (elastic#86631)
  [Discover] Deangularize navbar in context app (elastic#86353)
  skip "should schedule actions on legacy alerts" elastic#87010
  🍾 update notice text for 2021
  [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056)
  Enable prototype pollution protection in TSVB (elastic#85952)
  [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073)
  [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063)
  Adds more URLs to the docs links service (elastic#86972)
  Add missing backticks in reporting-settings.asciidoc (elastic#77979)
  [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050)
  [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033)
  [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
cauemarcondes added a commit that referenced this pull request Jan 4, 2021
@cauemarcondes @kibanamachine
[APM] Custom links can still be created with a read only user. (#87089)…
111a096 
… (#87140)

* disabling buttons when user does not permission

* fixing test

* disabling create/edit button when user does not have write permission

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Jan 4, 2021
@cauemarcondes @kibanamachine
[APM] Custom links can still be created with a read only user. (#87089)…
10c0d93 
… (#87139)

* disabling buttons when user does not permission

* fixing test

* disabling create/edit button when user does not have write permission

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Custom links can still be created with a read only user.
6 participants
@cauemarcondes @elasticmachine @formgeist @dgieselaar @kibanamachine @sorenlouv