Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more URLs to the docs links service #86972

Merged
merged 5 commits into from
Dec 30, 2020
Merged

Adds more URLs to the docs links service #86972

merged 5 commits into from
Dec 30, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 28, 2020

Summary

This PR adds some observability, security, monitoring, alerting, and machine learning links to the documentation link service. These links are currently hard-corded in various apps, so ideally they can be pulled from this list of URLs instead (in subsequent PRs).

@lcawl lcawl added v8.0.0 v7.12.0 Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 28, 2020
@lcawl lcawl marked this pull request as ready for review December 29, 2020 17:25
@lcawl lcawl requested a review from a team as a code owner December 29, 2020 17:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Dec 29, 2020
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
@lcawl
Copy link
Contributor Author

lcawl commented Dec 30, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47267 48027 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 556.2KB 558.1KB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit e348664 into elastic:master Dec 30, 2020
@lcawl lcawl deleted the ml-links branch December 30, 2020 19:29
lcawl added a commit to lcawl/kibana that referenced this pull request Dec 30, 2020
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
lcawl added a commit that referenced this pull request Dec 31, 2020
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 4, 2021
…meline-component

* 'master' of github.com:elastic/kibana: (955 commits)
  remove SameSite:None workaround (elastic#86994)
  URL encoding for URL drilldown (elastic#86902)
  [Security Solution] Fix few styling issues (elastic#87045)
  [APM] Custom links can still be created with a read only user. (elastic#87089)
  prevent double update (elastic#86794)
  Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113)
  [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093)
  [APM] Add range query to service map trace walk (elastic#86631)
  [Discover] Deangularize navbar in context app (elastic#86353)
  skip "should schedule actions on legacy alerts" elastic#87010
  🍾 update notice text for 2021
  [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056)
  Enable prototype pollution protection in TSVB (elastic#85952)
  [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073)
  [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063)
  Adds more URLs to the docs links service (elastic#86972)
  Add missing backticks in reporting-settings.asciidoc (elastic#77979)
  [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050)
  [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033)
  [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants