Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing the global search bar will reset suggestions #88637

Merged
merged 5 commits into from
May 13, 2021
Merged

Clearing the global search bar will reset suggestions #88637

merged 5 commits into from
May 13, 2021

Conversation

jamesrowe08
Copy link
Contributor

@jamesrowe08 jamesrowe08 commented Jan 19, 2021 •
edited by afharo
Loading

Summary

Resolves #88139. Clearing the global search bar with the "x" icon will now reset suggestions.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@jamesrowe08 jamesrowe08 requested a review from a team as a code owner January 19, 2021 01:10
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@pgayvallet
Copy link
Contributor

Jenkins, test this

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:AppServices labels Jan 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 19, 2021
@mshustov
Copy link
Contributor

mshustov commented Feb 3, 2021

@elasticmachine merge upstream

pgayvallet
pgayvallet approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@jamesrowe08
Copy link
Contributor Author

@pgayvallet thanks. Is there anything else I need to do for this to get merged?

@pgayvallet
Copy link
Contributor

@elasticmachine merge upstream

@pgayvallet
Copy link
Contributor

@jamesrowe08 my apologies, I thought this was merged a long time ago already. Will merge on green CI.

@pgayvallet
Copy link
Contributor

@elasticmachine merge upstream

@pgayvallet
Copy link
Contributor

@elastic/kibana-operations That's the third rebuild I force with a rebase, and both kibana-ci and elasticsearch-ci/docs are stuck every time. Do you have any idea why?

@jbudz
Copy link
Member

jbudz commented May 12, 2021

With community pull requests we have to manually trigger the builds

@jbudz
Copy link
Member

jbudz commented May 12, 2021

@elasticmachine run elasticsearch-ci/docs

@jbudz
Copy link
Member

jbudz commented May 12, 2021

jenkins, test it

@afharo
Copy link
Member

afharo commented May 13, 2021

@elasticmachine merge upstream

@afharo
Copy link
Member

afharo commented May 13, 2021

jenkins, test it

@afharo afharo added the auto-backport Deprecated - use backport:version if exact versions are needed label May 13, 2021
@afharo
Copy link
Member

afharo commented May 13, 2021

jenkins, test it

@afharo afharo enabled auto-merge (squash) May 13, 2021 11:24
@tylersmalley
Copy link
Contributor

Jenkins, test it

@afharo
Copy link
Member

afharo commented May 13, 2021

@elasticmachine run elasticsearch-ci/docs

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearchBar 34.6KB 34.6KB -7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit c4529fa into elastic:master May 13, 2021
@kibanamachine kibanamachine mentioned this pull request May 13, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 13, 2021
@jamesrowe08 @kibanamachine
Clearing the global search bar will reset suggestions (elastic#88637)
98b5061 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 13, 2021
@kibanamachine @jamesrowe08
Clearing the global search bar will reset suggestions (#88637) (#100046)
facd1a4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Rowe <jamesrowe08@gmail.com>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 17, 2021
@jamesrowe08 @kibanamachine @yctercero
Clearing the global search bar will reset suggestions (elastic#88637)
607f4b5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@jamesrowe08 @kibanamachine @yctercero
Clearing the global search bar will reset suggestions (elastic#88637)
95bef47 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0
Projects
None yet
Milestone
No milestone
9 participants
@jamesrowe08 @kibanamachine @elasticmachine @pgayvallet @mshustov @jbudz @afharo @tylersmalley @timroes