Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures we always select the correct index in UI tests #88876

Merged
merged 1 commit into from Jan 21, 2021
Merged

Ensures we always select the correct index in UI tests #88876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 12 additions & 3 deletions x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors.ts
View file
Open in desktop
Expand Up @@ -17,8 +17,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const comboBox = getService('comboBox');
const supertest = getService('supertest');

// FLAKY: https://github.com/elastic/kibana/issues/88796
describe.skip('Connectors', function () {
describe('Connectors', function () {
const objectRemover = new ObjectRemover(supertest);

before(async () => {
Expand Down Expand Up @@ -285,7 +284,17 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await testSubjects.setValue('nameInput', connectorName);

await comboBox.set('connectorIndexesComboBox', indexName);
await retry.try(async () => {
// At times we find the driver controlling the ComboBox in tests
// can select the wrong item, this ensures we always select the correct index
await comboBox.set('connectorIndexesComboBox', indexName);
expect(
await comboBox.isOptionSelected(
await testSubjects.find('connectorIndexesComboBox'),
indexName
)
).to.be(true);
});

await find.clickByCssSelector('[data-test-subj="saveNewActionButton"]:not(disabled)');
await pageObjects.common.closeToast();
Expand Down