Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI][Logs UI] Completely remove GraphQL and Apollo #89036

Merged
merged 6 commits into from
Feb 2, 2021
Merged

[Metrics UI][Logs UI] Completely remove GraphQL and Apollo #89036

merged 6 commits into from
Feb 2, 2021

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jan 21, 2021 •
edited
Loading

Summary

This PR closes #73526 by removing all the reference to GraphQL (resolvers, types, etc) and the Apollo client.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0 labels Jan 21, 2021
@simianhacker
Copy link
Member Author

@elastic/logs-ui There are a few types that I needed to copy over from the graphql/types. I did a quick poking around in the UI and everything seems to work but I would feel more comfortable if someone took a look to verify.

@simianhacker simianhacker marked this pull request as ready for review January 27, 2021 02:49
@simianhacker simianhacker requested a review from a team as a code owner January 27, 2021 02:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

phillipb
phillipb approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beautiful.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1108 1047 -61

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.2MB 1.9MB -333.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit cf846bd into elastic:master Feb 2, 2021
@simianhacker simianhacker mentioned this pull request Feb 3, 2021
Merged
simianhacker added a commit to simianhacker/kibana that referenced this pull request Feb 3, 2021
@simianhacker
[Metrics UI][Logs UI] Completely remove GraphQL and Apollo (elastic#8…
0ed2ddd 
…9036)
simianhacker added a commit that referenced this pull request Feb 3, 2021
@simianhacker
[Metrics UI][Logs UI] Completely remove GraphQL and Apollo (#89036) (#…
b186524 
…90108)
@simianhacker simianhacker deleted the issue-73526-remove-graphql branch April 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] [Logs UI] Remove all references to Apollo and GraphQL
4 participants
@simianhacker @elasticmachine @kibanamachine @phillipb