Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] show incomplete data boundary when MVT tile does not contain all features #90194

Closed
wants to merge 16 commits into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 3, 2021

This PR updates the behavior of MVT getTile route from showing a single bounding box when there are too many individual features to show all of the data, to showing the first X matching features and including a box notifying users that an area contains incomplete data.

Screen Shot 2021-02-03 at 7 59 51 AM

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 3, 2021
@nreese nreese requested a review from a team as a code owner February 3, 2021 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@spalger
Copy link
Contributor

spalger commented Feb 3, 2021

jenkins test this

@nreese
Copy link
Contributor Author

nreese commented Feb 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB -1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 138.4KB 138.2KB -193.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Feb 4, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Feb 5, 2021

Blocked by #90440.

Uncanceled requests causes performance problems when trying to pull too many tiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants