Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12] Put environment back in uiFilters (#92561) #92687

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 24, 2021

Backports the following commits to 7.12:

`environment` is still used in `uiFilters` in UX, but not anywhere else.

It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back.
# Conflicts:
#	x-pack/plugins/apm/public/context/url_params_context/url_params_context.tsx
@smith smith added the backport label Feb 24, 2021
@smith smith enabled auto-merge (squash) February 24, 2021 18:19
@dgieselaar
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB +31.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 178481b into elastic:7.12 Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants