Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Updated doc links to use dynamic prefixes #92968

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

JasonStoltz
Copy link
Member

Summary

I noticed a couple of places where we were not using dynamic doc links. I can't think of any reason why we'd want this, so I updated them to use the dynamic prefixes.

For maintainers

@JasonStoltz JasonStoltz requested review from a team as code owners February 26, 2021 14:24
@JasonStoltz JasonStoltz added v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Feb 26, 2021
Copy link

@akashgp09 akashgp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JasonStoltz
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.9MB 2.0MB +4.9KB
triggersActionsUi 1.6MB 1.5MB -23.9KB
total -19.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Workplace Search. Verified the new links work. Thanks for knocking this out!

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this Jason!

@@ -12,6 +12,7 @@ import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';

import { ENTERPRISE_SEARCH_PLUGIN } from '../../../../../common/constants';
import { DOCS_PREFIX } from '../../../app_search/routes';
Copy link
Member

@cee-chen cee-chen Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although as a quick note on this - whenever @chriscressman changes our docs, we should update our Setup Guide links to link out to a single shared Enterprise Search authentication doc page instead of using AS/WS specific auth docs

@JasonStoltz JasonStoltz merged commit 16a3780 into elastic:master Mar 2, 2021
@JasonStoltz JasonStoltz deleted the update-doc-links branch March 2, 2021 12:39
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #93204

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 2, 2021
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana:
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150)
  Cleanup Security plugin imports (elastic#93056)
  [Security Solution] - Bug fixes (elastic#92294)
  Updated doc links (elastic#92968)
  [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028)
  [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants