Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Remove platform from archive root directory #93835

Merged
merged 4 commits into from
Mar 15, 2021
Merged

[build] Remove platform from archive root directory #93835

merged 4 commits into from
Mar 15, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Mar 5, 2021

Currently our zip and tar.gz outputs a top level folder name
kibana-{version}-{platform}. In order to align with Elasticsearch, the
changes here remove {platform} from the folder name.

Before:
kibana-8.0.0-SNAPSHOT-linux-aarch64.tar.gz -> kibana-8.0.0-SNAPSHOT-aarch64

After:
kibana-8.0.0-SNAPSHOT-linux-aarch64.tar.gz -> kibana-8.0.0-SNAPSHOT

Closes #86898

Release note
Removes platform from root folder name for .tar.gz and .zip archives

@jbudz
[build] Remove platform from archive root directory
d6582ca 
Currently our zip and tar.gz outputs a top level folder name
kibana-{version}-{platform}.  In order to align with Elasticsearch, the
changes here remove {platform} from the folder name.

Before:
`kibana-8.0.0-SNAPSHOT-linux-aarch64.tar.gz ->
kibana-8.0.0-SNAPSHOT-aarch64`

After:
`kibana-8.0.0-SNAPSHOT-linux-aarch64.tar.gz ->
kibana-8.0.0-SNAPSHOT`

Closes elastic#86898
@jbudz jbudz added release_note:breaking Team:Operations Team label for Operations Team v8.0.0 labels Mar 5, 2021
@jbudz jbudz requested a review from a team as a code owner March 5, 2021 20:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member Author

jbudz commented Mar 5, 2021

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Mar 5, 2021

cc @elastic/kibana-qa - will this impact any automation? Any concerns here?

@LeeDr
Copy link
Contributor

LeeDr commented Mar 5, 2021

cc @elastic/kibana-qa - will this impact any automation? Any concerns here?

I don't think it will have much impact on integration-test repo. @liza-mae is out today so I can't really say on the estf stack testing. I think you should probably go ahead and we'll fix any issues that come up.

spalger
spalger approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archive from the latest build LGTM

image

@jbudz
Copy link
Member Author

jbudz commented Mar 15, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Mar 15, 2021

I've taken a look upstream to see if this is going to cause issues - as far as I can tell we're setting the folder name.

I'm going to monitor closely and revert if we identify any breaks.

@jbudz jbudz merged commit 511accd into elastic:master Mar 15, 2021
@jbudz jbudz deleted the build/remove-archive-platform branch March 15, 2021 19:41
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 17, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 93835 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Mar 17, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:breaking Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove platform from root directory in archives
5 participants
@jbudz @elasticmachine @LeeDr @kibanamachine @spalger