remove legacy doc links file

[pgayvallet]

Summary

Remove the legacy doc link stub file we added in #76354 as elastic/docs#1953 added lookup from core's src/core/public/doc_links/doc_links_service.ts

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[pgayvallet]

@elastic/kibana-docs can you confirm that the elasticsearch-ci/docs job will be alright with this change?

The failure ignored because this PR doesn't contain docs message on the job scares me.

[lcawl]

LGTM

[pgayvallet]

This PR is currently blocked because removing the legacy doc file actually cause the doc build validation script to correctly uses core's docLink service (which was never the case until now), revealing a few issues:

It seems like there are three types of broken links in docs_links_service.ts:

• Links that start with ${ELASTIC_WEBSITE_URL} but go to places other than the docs (like blog pages or marketing pages). We can’t check these links as part of the docs build, so we should ignore these. I’ll work on a change in elastic/docs.
• Links to the enterprise-search docs. These don’t work because we don’t publish the master branch of those docs. I’m not sure what to do with these.
• Actual broken links to things under en/kibana which should be fixed

Currently broken links are:

06:44:04 INFO:build_docs:  Kibana [master]: src/core/public/doc_links/doc_links_service.ts contains broken links to:
06:44:04 INFO:build_docs:   - ${ELASTIC_WEBSITE_URL}blog/external-collection-for-elastic-stack-monitoring-is-now-available-via-metricbeat
06:44:04 INFO:build_docs:   - ${ELASTIC_WEBSITE_URL}maps
06:44:04 INFO:build_docs:   - ${ELASTIC_WEBSITE_URL}what-is/kibana-lens
06:44:04 INFO:build_docs:   - en/app-search/master
06:44:04 INFO:build_docs:   - en/enterprise-search/master
06:44:04 INFO:build_docs:   - en/kibana/master/alert-type-index-threshold.html#index-action-configuration
06:44:04 INFO:build_docs:   - en/kibana/master/tutorial-load-dataset.html
06:44:04 INFO:build_docs:   - en/workplace-search/master

Links from category 3, which need actual fixing from the docLink definition, are:

06:44:04 INFO:build_docs:   - en/kibana/master/alert-type-index-threshold.html#index-action-configuration
06:44:04 INFO:build_docs:   - en/kibana/master/tutorial-load-dataset.html

cc @gtback

[pgayvallet]

en/kibana/master/tutorial-load-dataset.html

This one is indexPatterns.loadingData

kibana/src/core/public/doc_links/doc_links_service.ts

Line 123 in a102fa9

loadingData: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/tutorial-load-dataset.html`,

Link is indeed a 404 on the site. It seems the link is unused in the code base too, so I will just remove it - 0bb1877

en/kibana/master/alert-type-index-threshold.html#index-action-configuration

This one is alerting.indexThreshold

kibana/src/core/public/doc_links/doc_links_service.ts

Line 194 in a102fa9

indexThreshold: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/alert-type-index-threshold.html#index-action-configuration`,

used here:

kibana/x-pack/plugins/stack_alerts/public/alert_types/threshold/index.ts

Line 21 in a102fa9

documentationUrl: (docLinks) => docLinks.links.alerting.indexThreshold,

cc @elastic/kibana-alerting-services Do you mind fixing that one, or telling me what to replace the target with?

EDIT: it seems https://www.elastic.co/guide/en/kibana/master/alert-type-index-threshold.html#index-action-configuration do exist, but the anchor (#index-action-configuration) is not found on the page. Should we just remove it?

Removed the anchor - b77eb21

[ymao1]

EDIT: it seems https://www.elastic.co/guide/en/kibana/master/alert-type-index-threshold.html#index-action-configuration do exist, but the anchor (#index-action-configuration) is not found on the page. Should we just remove it?

Yes, it should be fine to remove just the anchor.

[pgayvallet]

@gtback I fixed the two link that were targeting Kibana docs.

Could you please check the CI doc build job to confirm that there are no more link from the Actual broken links to things under en/kibana which should be fixed category?

Do you also have any visibility on when the team will be able to fix the two other categories?

[gtback]

@elasticmachine merge upstream

[gtback]

@pgayvallet these are the remaining broken links:

08:12:36 INFO:build_docs:  Kibana [master]: src/core/public/doc_links/doc_links_service.ts contains broken links to:
08:12:36 INFO:build_docs:   - en/elasticsearch/reference/master/search-aggregations.html#_values_source
08:12:36 INFO:build_docs:   - en/kibana/master/alert-type-es-query.html
08:12:36 INFO:build_docs:   - en/kibana/master/alert-type-index-threshold.html
08:12:36 INFO:build_docs:   - en/kibana/master/pre-configured-action-types-and-connectors.html

[pgayvallet]

08:12:36 INFO:build_docs:   - en/elasticsearch/reference/master/search-aggregations.html#_values_source

scriptedFields.scriptAggs. Invalid anchor, will remove it

08:12:36 INFO:build_docs:   - en/kibana/master/alert-type-es-query.html

alerting.esQuery

08:12:36 INFO:build_docs:   - en/kibana/master/alert-type-index-threshold.html

alerting.indexThreshold

08:12:36 INFO:build_docs:   - en/kibana/master/pre-configured-action-types-and-connectors.html

alerting.preconfiguredConnectors

These 3 are redirecting to real 404 though. @elastic/kibana-alerting-services Could you take a look and tell me what the correct urls would be?

[ymao1]

These 3 are redirecting to real 404 though. @elastic/kibana-alerting-services Could you take a look and tell me what the correct urls would be?

Those were changed as part of the terminology update PR. Sorry for not updating them in that PR!

• en/kibana/master/alert-type-es-query.html -> en/kibana/master/rule-type-es-query.html
• en/kibana/master/alert-type-index-threshold.html -> en/kibana/master/rule-type-index-threshold.html
• en/kibana/master/pre-configured-action-types-and-connectors.html -> en/kibana/master/pre-configured-connectors.html

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: abd7558
• Storybooks Preview
• Documentation Changes

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
core	433.5KB	433.4KB	-160.0B

History

• 💚 Build #113648 succeeded e8bce0f
• 💔 Build #113608 failed c46074f
• 💔 Build #113003 failed 8818cd8
• 💔 Build #112709 failed 0bb1877
• 💚 Build #112422 succeeded c5e1ed6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream