Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another location to check for Kibana links #1953

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Add another location to check for Kibana links #1953

merged 2 commits into from
Sep 2, 2020

Conversation

gtback
Copy link
Member

@gtback gtback commented Sep 2, 2020

In the newest branches of the kibana repo, the file is in a new location.

After merging, it should be fine to undo elastic/kibana#76354.

cc: @pgayvallet

@gtback gtback added the link-checking Link Checking & Redirects label Sep 2, 2020
@gtback gtback requested a review from nik9000 September 2, 2020 20:27
nik9000
nik9000 approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This isn't the best way to deal with this stuff, but it works. Might be worth adding an integration test for this but it is a fair bit of work.

@gtback gtback merged commit 09e28f2 into master Sep 2, 2020
@gtback gtback deleted the add-kibana-links-file branch September 2, 2020 22:09
@pgayvallet pgayvallet mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
link-checking Link Checking & Redirects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtback @nik9000