Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics exploration: ensure training filters work as expected #96500

Merged
merged 1 commit into from
Apr 12, 2021
Merged

[ML] Data Frame Analytics exploration: ensure training filters work as expected #96500

merged 1 commit into from
Apr 12, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Apr 7, 2021 •
edited
Loading

Summary

Fixes #96072

Ensures training quick filters work when results field name is not the default.

image

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@alvarezmelissa87 alvarezmelissa87 self-assigned this Apr 7, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner April 7, 2021 20:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 requested review from qn895, peteharverson, walterra and darnautov and removed request for walterra April 7, 2021 20:31
@qn895
Copy link
Member

qn895 commented Apr 7, 2021

Tested and LGTM 🎉

darnautov
darnautov reviewed Apr 8, 2021
View reviewed changes
...pages/analytics_exploration/components/exploration_page_wrapper/exploration_page_wrapper.tsx
),
},
],
columnId: `${resultsField}.is_training`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to apply an encoding in case the resultsFields contains special characters?

@peteharverson
Copy link
Contributor

peteharverson commented Apr 8, 2021 •
edited by alvarezmelissa87
Loading

Testing this I noticed there seems to be an issue with the query to load the evaluate data, in that it doesn't pass through the name of the top_classes_field, which causes the ROC curve to fail to load:

image

Looks like the config in loadEvalData in ml/public/application/data_frame_analytics/common/analytics.ts also needs to set top_classes_field to use the results field name.

Could this be included as part of this PR?

Thanks for taking a look @peteharverson 🙏

Took a quick look and I'm not sure why this is happening. As it is unrelated to the changes in the PR I went ahead and created a separate bug issue for this #96603 so it can be addressed in a separate PR.

peteharverson
peteharverson approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior of Testing / Training filter LGTM.

Makes more sense to fix the issue with the ROC curve and top_classes_field in a separate PR.

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 987e9b8 into elastic:master Apr 12, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Apr 12, 2021
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Apr 12, 2021
@alvarezmelissa87
fix training quick filters (elastic#96500)
1a3cba9
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-fix-training-filter branch April 12, 2021 16:32
alvarezmelissa87 added a commit that referenced this pull request Apr 12, 2021
@alvarezmelissa87 @kibanamachine
fix training quick filters (#96500) (#96829)
ee5cc66 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov left review comments

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Training filters not filtering correctly if results field name is different
6 participants
@alvarezmelissa87 @elasticmachine @qn895 @peteharverson @kibanamachine @darnautov