Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Enable distance filtering on geo_shape #96832

Merged
merged 1 commit into from
Apr 12, 2021
Merged

[Maps] Enable distance filtering on geo_shape #96832

merged 1 commit into from
Apr 12, 2021

Conversation

thomasneirynck
Copy link
Contributor

Closes #82479

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB -217.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck marked this pull request as ready for review April 12, 2021 18:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

nreese
nreese approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@thomasneirynck thomasneirynck changed the title [Maps] Enable distance drawing on geo_shape [Maps] Enable distance filtering on geo_shape Apr 12, 2021
@thomasneirynck thomasneirynck merged commit 465734a into elastic:master Apr 12, 2021
@thomasneirynck thomasneirynck mentioned this pull request Apr 12, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Apr 12, 2021
@thomasneirynck
[Maps] Enable distance filtering on geo_shape (elastic#96832)
9d8936d
thomasneirynck added a commit that referenced this pull request Apr 12, 2021
@thomasneirynck
[Maps] Enable distance filtering on geo_shape (#96832) (#96891)
1f7c324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Enable distance filtering on geo_shape
4 participants
@thomasneirynck @kibanamachine @elasticmachine @nreese